Skip to content

Commit 7a6f0de

Browse files
authored
Fixed an invalid argument configuration (#2099)
* Fixed an invalid argument configuration * Applied sync conversion tool for parallel code
1 parent 5483dcf commit 7a6f0de

File tree

4 files changed

+38
-4
lines changed

4 files changed

+38
-4
lines changed

src/confluent_kafka/schema_registry/_async/schema_registry_client.py

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -667,7 +667,13 @@ async def register_schema_full_response(
667667
if schema_id is not None:
668668
result = self._cache.get_schema_by_id(subject_name, schema_id)
669669
if result is not None:
670-
return RegisteredSchema(schema_id, result[0], result[1], subject_name, None)
670+
return RegisteredSchema(
671+
schema_id=schema_id,
672+
guid=result[0],
673+
subject=subject_name,
674+
version=None,
675+
schema=result[1]
676+
)
671677

672678
request = schema.to_dict()
673679

@@ -682,7 +688,7 @@ async def register_schema_full_response(
682688
guid=result.guid,
683689
subject=result.subject or subject_name,
684690
version=result.version,
685-
schema=result.schema,
691+
schema=result.schema
686692
)
687693

688694
# The registered schema may not be fully populated

src/confluent_kafka/schema_registry/_sync/schema_registry_client.py

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -667,7 +667,13 @@ def register_schema_full_response(
667667
if schema_id is not None:
668668
result = self._cache.get_schema_by_id(subject_name, schema_id)
669669
if result is not None:
670-
return RegisteredSchema(schema_id, result[0], result[1], subject_name, None)
670+
return RegisteredSchema(
671+
schema_id=schema_id,
672+
guid=result[0],
673+
subject=subject_name,
674+
version=None,
675+
schema=result[1]
676+
)
671677

672678
request = schema.to_dict()
673679

@@ -682,7 +688,7 @@ def register_schema_full_response(
682688
guid=result.guid,
683689
subject=result.subject or subject_name,
684690
version=result.version,
685-
schema=result.schema,
691+
schema=result.schema
686692
)
687693

688694
# The registered schema may not be fully populated

tests/schema_registry/_async/test_api_client.py

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -87,6 +87,17 @@ async def test_register_schema(mock_schema_registry, load_avsc):
8787
assert result == SCHEMA_ID
8888

8989

90+
async def test_register_schema_full_response_recall(mock_schema_registry, load_avsc):
91+
conf = {'url': TEST_URL}
92+
sr = AsyncSchemaRegistryClient(conf)
93+
schema = Schema(load_avsc('basic_schema.avsc'), schema_type='AVRO')
94+
95+
await sr.register_schema('test-key', schema)
96+
97+
result = await sr.register_schema_full_response('test-key', schema)
98+
assert result.schema_id == SCHEMA_ID
99+
100+
90101
async def test_register_schema_incompatible(mock_schema_registry, load_avsc):
91102
conf = {'url': TEST_URL}
92103
sr = AsyncSchemaRegistryClient(conf)

tests/schema_registry/_sync/test_api_client.py

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -87,6 +87,17 @@ def test_register_schema(mock_schema_registry, load_avsc):
8787
assert result == SCHEMA_ID
8888

8989

90+
def test_register_schema_full_response_recall(mock_schema_registry, load_avsc):
91+
conf = {'url': TEST_URL}
92+
sr = SchemaRegistryClient(conf)
93+
schema = Schema(load_avsc('basic_schema.avsc'), schema_type='AVRO')
94+
95+
sr.register_schema('test-key', schema)
96+
97+
result = sr.register_schema_full_response('test-key', schema)
98+
assert result.schema_id == SCHEMA_ID
99+
100+
90101
def test_register_schema_incompatible(mock_schema_registry, load_avsc):
91102
conf = {'url': TEST_URL}
92103
sr = SchemaRegistryClient(conf)

0 commit comments

Comments
 (0)