Skip to content

Commit 8e5fc5e

Browse files
committed
SR integration tests relied on SR at :8081 despite Trivup fixture
1 parent d0bcd42 commit 8e5fc5e

File tree

2 files changed

+9
-9
lines changed

2 files changed

+9
-9
lines changed

tests/integration/schema_registry/test_json_serializers.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ def test_json_record_serialization(kafka_cluster, load_file):
9191
9292
"""
9393
topic = kafka_cluster.create_topic("serialization-json")
94-
sr = kafka_cluster.schema_registry({'url': 'http://localhost:8081'})
94+
sr = kafka_cluster.schema_registry()
9595

9696
schema_str = load_file("product.json")
9797
value_serializer = JSONSerializer(schema_str, sr)
@@ -139,7 +139,7 @@ def test_json_record_serialization_incompatible(kafka_cluster, load_file):
139139
140140
"""
141141
topic = kafka_cluster.create_topic("serialization-json")
142-
sr = kafka_cluster.schema_registry({'url': 'http://localhost:8081'})
142+
sr = kafka_cluster.schema_registry()
143143

144144
schema_str = load_file("product.json")
145145
value_serializer = JSONSerializer(schema_str, sr)
@@ -165,7 +165,7 @@ def test_json_record_serialization_no_title(kafka_cluster, load_file):
165165
load_file (callable(str)): JSON Schema file reader
166166
167167
"""
168-
sr = kafka_cluster.schema_registry({'url': 'http://localhost:8081'})
168+
sr = kafka_cluster.schema_registry()
169169
schema_str = load_file('not_title.json')
170170

171171
with pytest.raises(ValueError,
@@ -184,7 +184,7 @@ def test_json_record_serialization_custom(kafka_cluster, load_file):
184184
185185
"""
186186
topic = kafka_cluster.create_topic("serialization-json")
187-
sr = kafka_cluster.schema_registry({'url': 'http://localhost:8081'})
187+
sr = kafka_cluster.schema_registry()
188188

189189
schema_str = load_file("product.json")
190190
value_serializer = JSONSerializer(schema_str, sr,
@@ -228,7 +228,7 @@ def test_json_record_deserialization_mismatch(kafka_cluster, load_file):
228228
229229
"""
230230
topic = kafka_cluster.create_topic("serialization-json")
231-
sr = kafka_cluster.schema_registry({'url': 'http://localhost:8081'})
231+
sr = kafka_cluster.schema_registry()
232232

233233
schema_str = load_file("contractor.json")
234234
schema_str2 = load_file("product.json")

tests/integration/schema_registry/test_proto_serializers.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ def test_protobuf_message_serialization(kafka_cluster, pb2, data):
5454
5555
"""
5656
topic = kafka_cluster.create_topic("serialization-proto")
57-
sr = kafka_cluster.schema_registry({'url': 'http://localhost:8081'})
57+
sr = kafka_cluster.schema_registry()
5858

5959
value_serializer = ProtobufSerializer(pb2, sr)
6060
value_deserializer = ProtobufDeserializer(pb2)
@@ -85,7 +85,7 @@ def test_protobuf_reference_registration(kafka_cluster, pb2, expected_refs):
8585
Registry to ensure the references match up.
8686
8787
"""
88-
sr = kafka_cluster.schema_registry({'url': 'http://localhost:8081'})
88+
sr = kafka_cluster.schema_registry()
8989
topic = kafka_cluster.create_topic("serialization-proto-refs")
9090
serializer = ProtobufSerializer(pb2, sr)
9191
producer = kafka_cluster.producer(key_serializer=serializer)
@@ -106,7 +106,7 @@ def test_protobuf_serializer_type_mismatch(kafka_cluster):
106106
pb2_1 = TestProto_pb2.TestMessage
107107
pb2_2 = NestedTestProto_pb2.NestedMessage
108108

109-
sr = kafka_cluster.schema_registry({'url': 'http://localhost:8081'})
109+
sr = kafka_cluster.schema_registry()
110110
topic = kafka_cluster.create_topic("serialization-proto-refs")
111111
serializer = ProtobufSerializer(pb2_1, sr)
112112

@@ -127,7 +127,7 @@ def test_protobuf_deserializer_type_mismatch(kafka_cluster):
127127
pb2_1 = PublicTestProto_pb2.TestMessage
128128
pb2_2 = metadata_proto_pb2.HDFSOptions
129129

130-
sr = kafka_cluster.schema_registry({'url': 'http://localhost:8081'})
130+
sr = kafka_cluster.schema_registry()
131131
topic = kafka_cluster.create_topic("serialization-proto-refs")
132132
serializer = ProtobufSerializer(pb2_1, sr)
133133
deserializer = ProtobufDeserializer(pb2_2)

0 commit comments

Comments
 (0)