Skip to content

Commit ee61203

Browse files
committed
Added new fixure for single broker and using this fixure for test_serializer tests
1 parent 3380c5a commit ee61203

File tree

3 files changed

+23
-16
lines changed

3 files changed

+23
-16
lines changed

tests/common/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525

2626

2727
def _trivup_cluster_type_kraft():
28-
return _TRIVUP_CLUSTER_TYPE_ENV in os.environ and os.environ[_TRIVUP_CLUSTER_TYPE_ENV] == 'kratf'
28+
return _TRIVUP_CLUSTER_TYPE_ENV in os.environ and os.environ[_TRIVUP_CLUSTER_TYPE_ENV] == 'kraft'
2929

3030

3131
def use_group_protocol_consumer():

tests/integration/conftest.py

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -120,6 +120,13 @@ def kafka_cluster():
120120
yield fixture
121121

122122

123+
@pytest.fixture(scope="package")
124+
def kafka_single_broker_cluster():
125+
for fixture in kafka_cluster_fixture(
126+
trivup_cluster_conf={'broker_cnt': 1}):
127+
yield fixture
128+
129+
123130
@pytest.fixture(scope="package")
124131
def sasl_cluster(request):
125132
for fixture in sasl_cluster_fixture(request.param):

tests/integration/serialization/test_serializers.py

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -31,12 +31,12 @@
3131
(IntegerSerializer(), IntegerDeserializer(), 4124),
3232
(DoubleSerializer(), DoubleDeserializer(), None),
3333
(IntegerSerializer(), IntegerDeserializer(), None)])
34-
def test_numeric_serialization(kafka_cluster, serializer, deserializer, data):
34+
def test_numeric_serialization(kafka_single_broker_cluster, serializer, deserializer, data):
3535
"""
3636
Tests basic serialization/deserialization of numeric types.
3737
3838
Args:
39-
kafka_cluster (KafkaClusterFixture): cluster fixture
39+
kafka_single_broker_cluster (KafkaClusterFixture): cluster fixture
4040
4141
serializer (Serializer): serializer to test
4242
@@ -45,13 +45,13 @@ def test_numeric_serialization(kafka_cluster, serializer, deserializer, data):
4545
data(object): input data
4646
4747
"""
48-
topic = kafka_cluster.create_topic("serialization-numeric")
48+
topic = kafka_single_broker_cluster.create_topic("serialization-numeric")
4949

50-
producer = kafka_cluster.producer(value_serializer=serializer)
50+
producer = kafka_single_broker_cluster.producer(value_serializer=serializer)
5151
producer.produce(topic, value=data)
5252
producer.flush()
5353

54-
consumer = kafka_cluster.consumer(value_deserializer=deserializer)
54+
consumer = kafka_single_broker_cluster.consumer(value_deserializer=deserializer)
5555
consumer.subscribe([topic])
5656

5757
msg = consumer.poll()
@@ -65,26 +65,26 @@ def test_numeric_serialization(kafka_cluster, serializer, deserializer, data):
6565
[(u'Jämtland', 'utf_8'),
6666
(u'Härjedalen', 'utf_16'),
6767
(None, 'utf_32')])
68-
def test_string_serialization(kafka_cluster, data, codec):
68+
def test_string_serialization(kafka_single_broker_cluster, data, codec):
6969
"""
7070
Tests basic unicode serialization/deserialization functionality
7171
7272
Args:
73-
kafka_cluster (KafkaClusterFixture): cluster fixture
73+
kafka_single_broker_cluster (KafkaClusterFixture): cluster fixture
7474
7575
data (unicode): input data
7676
7777
codec (str): encoding type
7878
7979
"""
80-
topic = kafka_cluster.create_topic("serialization-string")
80+
topic = kafka_single_broker_cluster.create_topic("serialization-string")
8181

82-
producer = kafka_cluster.producer(value_serializer=StringSerializer(codec))
82+
producer = kafka_single_broker_cluster.producer(value_serializer=StringSerializer(codec))
8383

8484
producer.produce(topic, value=data)
8585
producer.flush()
8686

87-
consumer = kafka_cluster.consumer(value_deserializer=StringDeserializer(codec))
87+
consumer = kafka_single_broker_cluster.consumer(value_deserializer=StringDeserializer(codec))
8888

8989
consumer.subscribe([topic])
9090

@@ -102,13 +102,13 @@ def test_string_serialization(kafka_cluster, data, codec):
102102
(StringSerializer('utf_16'), DoubleSerializer(),
103103
StringDeserializer('utf_16'), DoubleDeserializer(),
104104
u'Härjedalen', 1.2168215450814477)])
105-
def test_mixed_serialization(kafka_cluster, key_serializer, value_serializer,
105+
def test_mixed_serialization(kafka_single_broker_cluster, key_serializer, value_serializer,
106106
key_deserializer, value_deserializer, key, value):
107107
"""
108108
Tests basic mixed serializer/deserializer functionality.
109109
110110
Args:
111-
kafka_cluster (KafkaClusterFixture): cluster fixture
111+
kafka_single_broker_cluster (KafkaClusterFixture): cluster fixture
112112
113113
key_serializer (Serializer): serializer to test
114114
@@ -119,14 +119,14 @@ def test_mixed_serialization(kafka_cluster, key_serializer, value_serializer,
119119
value (object): value data
120120
121121
"""
122-
topic = kafka_cluster.create_topic("serialization-numeric")
122+
topic = kafka_single_broker_cluster.create_topic("serialization-numeric")
123123

124-
producer = kafka_cluster.producer(key_serializer=key_serializer,
124+
producer = kafka_single_broker_cluster.producer(key_serializer=key_serializer,
125125
value_serializer=value_serializer)
126126
producer.produce(topic, key=key, value=value)
127127
producer.flush()
128128

129-
consumer = kafka_cluster.consumer(key_deserializer=key_deserializer,
129+
consumer = kafka_single_broker_cluster.consumer(key_deserializer=key_deserializer,
130130
value_deserializer=value_deserializer)
131131
consumer.subscribe([topic])
132132

0 commit comments

Comments
 (0)