Skip to content

Commit 275cb6a

Browse files
committed
Added Unit Tests for generate.timeout config
1 parent 9728f7e commit 275cb6a

File tree

2 files changed

+28
-1
lines changed

2 files changed

+28
-1
lines changed

src/main/java/io/confluent/kafka/connect/datagen/DatagenConnectorConfig.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ public class DatagenConnectorConfig extends AbstractConfig {
5151
+ "Each task will generate different data than the other tasks in the same connector.";
5252
public static final String GENERATE_TIMEOUT_CONF = "generate.timeout";
5353
private static final String GENERATE_TIMEOUT_DOC = "Timeout in milliseconds for random message "
54-
+ "generation";
54+
+ "generation. This timeout can be configured for upto 1 minute, i.e 60000ms";
5555

5656
public DatagenConnectorConfig(ConfigDef config, Map<String, String> parsedConfig) {
5757
super(config, parsedConfig);

src/test/java/io/confluent/kafka/connect/datagen/DatagenConnectorTest.java

Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -220,6 +220,33 @@ public void shouldNotValidateSchemaKeyFieldWhenMultipleSchemaSourcesAreSet() {
220220
);
221221
}
222222

223+
@Test
224+
public void shouldAllowSettingGenerateTimeoutInRange() {
225+
clearSchemaSources();
226+
config.put(DatagenConnectorConfig.GENERATE_TIMEOUT_CONF, "100");
227+
config.put(DatagenConnectorConfig.SCHEMA_FILENAME_CONF, "product.avro");
228+
Config validated = connector.validate(config);
229+
assertThat(validated, hasNoValidationErrorsFor(DatagenConnectorConfig.GENERATE_TIMEOUT_CONF));
230+
}
231+
232+
@Test
233+
public void shouldNotAllowSettingGenerateTimeoutNegative() {
234+
clearSchemaSources();
235+
config.put(DatagenConnectorConfig.GENERATE_TIMEOUT_CONF, "-1");
236+
config.put(DatagenConnectorConfig.SCHEMA_FILENAME_CONF, "product.avro");
237+
Config validated = connector.validate(config);
238+
assertThat(validated, hasValidationError(DatagenConnectorConfig.GENERATE_TIMEOUT_CONF, 1));
239+
}
240+
241+
@Test
242+
public void shouldNotAllowSettingGenerateTimeoutOutOfRange() {
243+
clearSchemaSources();
244+
config.put(DatagenConnectorConfig.GENERATE_TIMEOUT_CONF, "70000");
245+
config.put(DatagenConnectorConfig.SCHEMA_FILENAME_CONF, "product.avro");
246+
Config validated = connector.validate(config);
247+
assertThat(validated, hasValidationError(DatagenConnectorConfig.GENERATE_TIMEOUT_CONF, 1));
248+
}
249+
223250
protected void assertTaskConfigs(int maxTasks) {
224251
List<Map<String, String>> taskConfigs = connector.taskConfigs(maxTasks);
225252
assertEquals(maxTasks, taskConfigs.size());

0 commit comments

Comments
 (0)