Skip to content

Commit 47d95e9

Browse files
committed
Minor refactoring
1 parent 0be2c79 commit 47d95e9

File tree

2 files changed

+7
-3
lines changed

2 files changed

+7
-3
lines changed

src/main/java/io/confluent/kafka/connect/datagen/DatagenConnectorConfig.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -171,11 +171,11 @@ public void ensureValid(String name, Object value) {
171171
if (((String) value).isEmpty()) {
172172
return;
173173
}
174-
if (!Quickstart.configValues.contains(((String) value).toLowerCase())) {
174+
if (!Quickstart.configValues().contains(((String) value).toLowerCase())) {
175175
throw new ConfigException(String.format(
176176
"%s must be one out of %s",
177177
name,
178-
String.join(",", DatagenTask.Quickstart.configValues)
178+
String.join(",", DatagenTask.Quickstart.configValues())
179179
));
180180
}
181181
}

src/main/java/io/confluent/kafka/connect/datagen/DatagenTask.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ protected enum Quickstart {
8787
STORES("stores.avro", "store_id"),
8888
CREDIT_CARDS("credit_cards.avro", "card_id");
8989

90-
static final Set<String> configValues;
90+
private static final Set<String> configValues;
9191

9292
static {
9393
ImmutableSet.Builder<String> immutableSetBuilder = ImmutableSet.builder();
@@ -106,6 +106,10 @@ protected enum Quickstart {
106106
this.keyName = keyName;
107107
}
108108

109+
public static Set<String> configValues() {
110+
return configValues;
111+
}
112+
109113
public String getSchemaFilename() {
110114
return schemaFilename;
111115
}

0 commit comments

Comments
 (0)