Skip to content

Commit b663c97

Browse files
committed
Added Unit Tests for generate.timeout config
1 parent 9728f7e commit b663c97

File tree

2 files changed

+25
-1
lines changed

2 files changed

+25
-1
lines changed

src/main/java/io/confluent/kafka/connect/datagen/DatagenConnectorConfig.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ public class DatagenConnectorConfig extends AbstractConfig {
5151
+ "Each task will generate different data than the other tasks in the same connector.";
5252
public static final String GENERATE_TIMEOUT_CONF = "generate.timeout";
5353
private static final String GENERATE_TIMEOUT_DOC = "Timeout in milliseconds for random message "
54-
+ "generation";
54+
+ "generation. This timeout can be configured for upto 1 minute, i.e 60000ms";
5555

5656
public DatagenConnectorConfig(ConfigDef config, Map<String, String> parsedConfig) {
5757
super(config, parsedConfig);

src/test/java/io/confluent/kafka/connect/datagen/DatagenConnectorTest.java

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -220,6 +220,30 @@ public void shouldNotValidateSchemaKeyFieldWhenMultipleSchemaSourcesAreSet() {
220220
);
221221
}
222222

223+
@Test
224+
public void shouldAllowSettingGenerateTimeoutInRange() {
225+
clearSchemaSources();
226+
config.put(DatagenConnectorConfig.GENERATE_TIMEOUT_CONF, "100");
227+
Config validated = connector.validate(config);
228+
assertThat(validated, hasNoValidationErrorsFor(DatagenConnectorConfig.GENERATE_TIMEOUT_CONF));
229+
}
230+
231+
@Test
232+
public void shouldNotAllowSettingGenerateTimeoutNegative() {
233+
clearSchemaSources();
234+
config.put(DatagenConnectorConfig.GENERATE_TIMEOUT_CONF, "-1");
235+
Config validated = connector.validate(config);
236+
assertThat(validated, hasValidationError(DatagenConnectorConfig.GENERATE_TIMEOUT_CONF, 1));
237+
}
238+
239+
@Test
240+
public void shouldNotAllowSettingGenerateTimeoutOutOfRange() {
241+
clearSchemaSources();
242+
config.put(DatagenConnectorConfig.GENERATE_TIMEOUT_CONF, "70000");
243+
Config validated = connector.validate(config);
244+
assertThat(validated, hasValidationError(DatagenConnectorConfig.GENERATE_TIMEOUT_CONF, 1));
245+
}
246+
223247
protected void assertTaskConfigs(int maxTasks) {
224248
List<Map<String, String>> taskConfigs = connector.taskConfigs(maxTasks);
225249
assertEquals(maxTasks, taskConfigs.size());

0 commit comments

Comments
 (0)