Skip to content

Commit 19f1b8d

Browse files
committed
nit: correct naming for partitions being sent to the ShareFetch request
1 parent 56a3e84 commit 19f1b8d

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

src/rdkafka_fetcher.c

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1474,12 +1474,12 @@ void rd_kafka_ShareFetchRequest(
14741474
int toppars_to_send_cnt = toppars_to_send ? rd_list_cnt(toppars_to_send) : 0;
14751475
int i;
14761476
size_t j;
1477-
rd_bool_t has_acknowledgements = toppars_to_send && rd_list_cnt(toppars_to_send) > 0 ? rd_true : rd_false;
1477+
rd_bool_t has_acknowledgements_or_topics_to_add = toppars_to_send && rd_list_cnt(toppars_to_send) > 0 ? rd_true : rd_false;
14781478
rd_bool_t has_toppars_to_forget = toppars_to_forget && rd_list_cnt(toppars_to_forget) > 0 ? rd_true : rd_false;
14791479
rd_bool_t is_fetching_messages = max_records > 0 ? rd_true : rd_false;
14801480

1481-
rd_kafka_dbg(rkb->rkb_rk, FETCH, "SHAREFETCH", "toppars_to_send_cnt=%d, has_acknowledgements=%d, has_toppars_to_forget=%d, is_fetching_messages=%d",
1482-
toppars_to_send_cnt, has_acknowledgements, has_toppars_to_forget, is_fetching_messages);
1481+
rd_kafka_dbg(rkb->rkb_rk, FETCH, "SHAREFETCH", "toppars_to_send_cnt=%d, has_acknowledgements_or_topics_to_add=%d, has_toppars_to_forget=%d, is_fetching_messages=%d",
1482+
toppars_to_send_cnt, has_acknowledgements_or_topics_to_add, has_toppars_to_forget, is_fetching_messages);
14831483
/*
14841484
* Only sending 1 aknowledgement for each partition. StartOffset + LastOffset + AcknowledgementType (ACCEPT for now).
14851485
* TODO KIP-932: Change this to accommodate explicit acknowledgements.
@@ -1648,10 +1648,10 @@ void rd_kafka_ShareFetchRequest(
16481648
rd_list_destroy(toppars_to_send);
16491649
}
16501650

1651-
if(is_leave_request || has_acknowledgements || has_toppars_to_forget || is_fetching_messages) {
1651+
if(is_leave_request || has_acknowledgements_or_topics_to_add || has_toppars_to_forget || is_fetching_messages) {
16521652
rd_kafka_dbg(rkb->rkb_rk, FETCH, "SHAREFETCH",
16531653
"Share Fetch Request sent with%s%s%s",
1654-
has_acknowledgements ? " acknowledgements," : "",
1654+
has_acknowledgements_or_topics_to_add ? " acknowledgements," : "",
16551655
has_toppars_to_forget ? " forgotten toppars," : "",
16561656
is_fetching_messages ? " fetching messages" : "");
16571657
} else {

0 commit comments

Comments
 (0)