Commit 33f3941
committed
[KIP-932] Fix intermittent test and add debug logging
1. Fix intermittent do_test_mixed_commit_types failure: add
rd_sleep(3) before consumer close to allow in-flight async
ack requests to complete. The race occurred when commit_async
grabbed acks from the inflight map but the broker response
hadn't arrived before consumer close tore down the connection.
Tighten commit_sync timing assertion from 5000ms to 500ms
2. Add debug logging to commit_async, ShareAcknowledge request
construction, and ack batch building for better observability
3. Add TODO KIP-932 comments for future improvements:
- Ack batch merging for adjacent/overlapping offset ranges
- Using abs_timeout instead of socket.timeout.ms for
ShareAcknowledge requests in commit_sync path1 parent 8549895 commit 33f3941
4 files changed
+179
-124
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3443 | 3443 | | |
3444 | 3444 | | |
3445 | 3445 | | |
| 3446 | + | |
| 3447 | + | |
| 3448 | + | |
| 3449 | + | |
| 3450 | + | |
| 3451 | + | |
| 3452 | + | |
| 3453 | + | |
| 3454 | + | |
| 3455 | + | |
| 3456 | + | |
| 3457 | + | |
| 3458 | + | |
| 3459 | + | |
3446 | 3460 | | |
3447 | 3461 | | |
3448 | 3462 | | |
| |||
4212 | 4226 | | |
4213 | 4227 | | |
4214 | 4228 | | |
| 4229 | + | |
| 4230 | + | |
4215 | 4231 | | |
4216 | 4232 | | |
4217 | 4233 | | |
| |||
4274 | 4290 | | |
4275 | 4291 | | |
4276 | 4292 | | |
| 4293 | + | |
| 4294 | + | |
| 4295 | + | |
4277 | 4296 | | |
4278 | 4297 | | |
4279 | 4298 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2651 | 2651 | | |
2652 | 2652 | | |
2653 | 2653 | | |
| 2654 | + | |
| 2655 | + | |
| 2656 | + | |
| 2657 | + | |
| 2658 | + | |
2654 | 2659 | | |
2655 | 2660 | | |
2656 | 2661 | | |
| |||
2690 | 2695 | | |
2691 | 2696 | | |
2692 | 2697 | | |
| 2698 | + | |
| 2699 | + | |
| 2700 | + | |
| 2701 | + | |
| 2702 | + | |
| 2703 | + | |
| 2704 | + | |
2693 | 2705 | | |
2694 | 2706 | | |
2695 | 2707 | | |
2696 | 2708 | | |
2697 | 2709 | | |
| 2710 | + | |
| 2711 | + | |
| 2712 | + | |
| 2713 | + | |
| 2714 | + | |
| 2715 | + | |
| 2716 | + | |
2698 | 2717 | | |
2699 | 2718 | | |
2700 | 2719 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
372 | 372 | | |
373 | 373 | | |
374 | 374 | | |
| 375 | + | |
| 376 | + | |
| 377 | + | |
| 378 | + | |
| 379 | + | |
| 380 | + | |
| 381 | + | |
375 | 382 | | |
376 | 383 | | |
377 | 384 | | |
| |||
0 commit comments