Skip to content

Commit 64a17ed

Browse files
authored
Merge pull request #3008 from joejstuart/KONFLUX-10573
Change default expires on to 60
2 parents eb80390 + f014222 commit 64a17ed

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

cmd/track/track_bundle.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ func trackBundleCmd(track trackBundleFn, pullImage pullImageFn, pushImage pushIm
4646
inEffectDays int
4747
}{
4848
prune: true,
49-
inEffectDays: 30,
49+
inEffectDays: 60,
5050
}
5151

5252
cmd := &cobra.Command{

cmd/track/track_bundle_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -228,7 +228,7 @@ func Test_TrackBundleCommand(t *testing.T) {
228228
if c.expectInEffectDays != 0 {
229229
assert.Equal(t, c.expectInEffectDays, inEffectDays)
230230
} else {
231-
assert.Equal(t, 30, inEffectDays)
231+
assert.Equal(t, 60, inEffectDays)
232232
}
233233
return []byte(testOutput), nil
234234
}
@@ -291,7 +291,7 @@ func TestBundleCommandHelp(t *testing.T) {
291291
trackBundleCmd.Flags().VisitAll(func(flag *pflag.Flag) {
292292
if flag.Name == "in-effect-days" {
293293
foundFlag = true
294-
assert.Equal(t, "30", flag.DefValue, "Default value should be 30")
294+
assert.Equal(t, "60", flag.DefValue, "Default value should be 60")
295295
}
296296
})
297297
assert.True(t, foundFlag, "in-effect-days flag should exist")

docs/modules/ROOT/pages/ec_track_bundle.adoc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ Update existing acceptable bundles:
6565
--freshen:: resolve image tags to catch updates and use the latest image for the tag (Default: false)
6666
-g, --git:: git references to track - may be used multiple times (Default: [])
6767
-h, --help:: help for bundle (Default: false)
68-
--in-effect-days:: number of days after which older bundle entries expire when a new bundle entry is added (most recent entry stays valid until replaced) (Default: 30)
68+
--in-effect-days:: number of days after which older bundle entries expire when a new bundle entry is added (most recent entry stays valid until replaced) (Default: 60)
6969
-i, --input:: existing tracking file
7070
-o, --output:: write modified tracking file to a file. Use empty string for stdout, default behavior
7171
-p, --prune:: remove entries that are no longer acceptable, i.e. a newer entry already effective exists (Default: true)

0 commit comments

Comments
 (0)