Skip to content

Commit 783e7d2

Browse files
committed
fix: address PR comment
* remove deprecated acceptance/coverage/coverage.go and related env vars
1 parent 94b1e83 commit 783e7d2

File tree

3 files changed

+1
-458
lines changed

3 files changed

+1
-458
lines changed

Makefile

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -126,8 +126,6 @@ acceptance: ## Run all acceptance tests
126126
cp -R . "$$ACCEPTANCE_WORKDIR"; \
127127
cd "$$ACCEPTANCE_WORKDIR" && \
128128
$(MAKE) build && \
129-
export COVERAGE_FILEPATH="$$ACCEPTANCE_WORKDIR"; \
130-
export COVERAGE_FILENAME="-acceptance"; \
131129
export GOCOVERDIR="$${ACCEPTANCE_WORKDIR}/coverage"; \
132130
cd acceptance && go test -timeout $(ACCEPTANCE_TIMEOUT) ./... ; go tool covdata textfmt -i=$${GOCOVERDIR} -o="$(ROOT_DIR)/coverage-acceptance.out"
133131

acceptance/cli/cli.go

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -87,9 +87,7 @@ func variables(ctx context.Context) (context.Context, []string, map[string]strin
8787
// fail if it can't locate the git command
8888
environment := []string{
8989
"PATH=" + os.Getenv("PATH"),
90-
"COVERAGE_FILEPATH=" + os.Getenv("COVERAGE_FILEPATH"), // where to put the coverage file, $COVERAGE_FILEPATH is provided by the Makefile, if empty it'll be $TMPDIR
91-
"COVERAGE_FILENAME=" + os.Getenv("COVERAGE_FILENAME"), // suffix for the coverage file
92-
"GOCOVERDIR=" + os.Getenv("GOCOVERDIR"), // directory where the Go coverage raw data is stored
90+
"GOCOVERDIR=" + os.Getenv("GOCOVERDIR"), // directory where the Go coverage raw data is stored
9391
"HOME=/tmp",
9492
}
9593

0 commit comments

Comments
 (0)