fix: validate falsy numbers (#177)

Co-authored-by: Dmitrii Fontanov <[email protected]>
Co-authored-by: James Mortemore <[email protected]>

Author: 3 people

lib/query-validation-visitor.js

@@ -278,7 +278,7 @@ class InputObjectValidationVisitor {
       validateArrayTypeValue(this.context, valueTypeDef, iFieldTypeDef, value, this.currentField, this.argName, this.variableName, iFieldNameFull)
     } else {
       // nothing to validate
-      if (!value && value !== '') return
+      if (!value && value !== '' && value !== 0) return
 
       validateScalarTypeValue(this.context, this.currentField, iFieldTypeDef, valueTypeDef, value, this.variableName, this.argName, iFieldNameFull, ` at "${iFieldNameFull}"`)
     }

test/int.test.js

@@ -49,6 +49,17 @@ module.exports.test = function (setup, implType) {
           'Variable "$input" got invalid value 2 at "input.title"' + valueByImplType(implType, '; Expected type "title_Int_NotNull_min_3"') + '. Must be at least 3')
       })
 
+      it('should fail with input = 0', async function () {
+        const { body, statusCode } = await this.request
+          .post('/graphql')
+          .set('Accept', 'application/json')
+          .send({ query, variables: { input: { title: 0 } } })
+
+        isStatusCodeError(statusCode, implType)
+        strictEqual(body.errors[0].message,
+          'Variable "$input" got invalid value 0 at "input.title"' + valueByImplType(implType, '; Expected type "title_Int_NotNull_min_3"') + '. Must be at least 3')
+      })
+
       if (isSchemaWrapperImplType(implType)) {
         it('should throw custom error', async function () {
           const request = await setup({ typeDefs: this.typeDefs, formatError })