fix: update number constraint args to floats (#82)

fixes #78

Author: pukuba

index.js

@@ -13,7 +13,12 @@ function constraintDirective () {
       uniqueTypeName = directiveArgumentMap.uniqueTypeName.replace(/\W/g, '')
     } else {
       uniqueTypeName = `${fieldName}_${type.name}_${notNull ? 'NotNull_' : ''}` + Object.entries(directiveArgumentMap)
-        .map(([key, value]) => `${key}_${value.toString().replace(/\W/g, '')}`)
+        .map(([key, value]) => {
+          if (key === 'min' || key === 'max' || key === 'exclusiveMin' || key === 'exclusiveMax' || key === 'multipleOf') {
+            return `${key}_${value.toString().replace(/\W/g, 'dot')}`
+          }
+          return `${key}_${value.toString().replace(/\W/g, '')}`
+        })
         .join('_')
     }
     const key = Symbol.for(uniqueTypeName)
@@ -86,11 +91,11 @@ const constraintDirectiveTypeDefs = `
     format: String
 
     # Number constraints
-    min: Int
-    max: Int
-    exclusiveMin: Int
-    exclusiveMax: Int
-    multipleOf: Int
+    min: Float
+    max: Float
+    exclusiveMin: Float
+    exclusiveMax: Float
+    multipleOf: Float
     uniqueTypeName: String
   ) on INPUT_FIELD_DEFINITION | FIELD_DEFINITION`
 

scalars/number.js

@@ -30,6 +30,11 @@ module.exports = class ConstraintNumberType extends GraphQLScalarType {
   }
 }
 
+function divisible (a, b) {
+  const eps = Number.EPSILON * 3
+  return a % b < eps || a % b > b - eps
+}
+
 function validate (fieldName, args, value) {
   if (args.min !== undefined && value < args.min) {
     throw new ValidationError(fieldName,
@@ -53,7 +58,7 @@ function validate (fieldName, args, value) {
       [{ arg: 'exclusiveMax', value: args.exclusiveMax }])
   }
 
-  if (args.multipleOf !== undefined && value % args.multipleOf !== 0) {
+  if (args.multipleOf !== undefined && divisible(value, args.multipleOf) === false) {
     throw new ValidationError(fieldName,
       `Must be a multiple of ${args.multipleOf}`,
       [{ arg: 'multipleOf', value: args.multipleOf }])