Skip to content

Commit 1330516

Browse files
committed
Cleanup
Signed-off-by: Anuraag Agrawal <[email protected]>
1 parent be0d36f commit 1330516

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

conformance/test/server.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -442,6 +442,7 @@ async def serve_granian(
442442
# Granian seems to have a bug that it prints out 0 rather than the resolved port,
443443
# so we need to determine it ourselves. If we see race conditions because of it,
444444
# we can set max-servers=1 in the runner.
445+
# ref: https://github.com/emmett-framework/granian/issues/711
445446
port = _find_free_port()
446447
args = [f"--port={port}", "--workers=8"]
447448
if certfile:
@@ -468,7 +469,7 @@ async def serve_granian(
468469
env=_server_env(request),
469470
)
470471
stdout = proc.stdout
471-
assert stdout is not None # noqa: S101
472+
assert stdout is not None
472473
stdout = _tee_to_stderr(stdout)
473474
try:
474475
async for line in stdout:
@@ -509,7 +510,7 @@ async def serve_gunicorn(
509510
env=_server_env(request),
510511
)
511512
stdout = proc.stdout
512-
assert stdout is not None # noqa: S101
513+
assert stdout is not None
513514
stdout = _tee_to_stderr(stdout)
514515
try:
515516
async for line in stdout:
@@ -554,7 +555,7 @@ async def serve_hypercorn(
554555
env=_server_env(request),
555556
)
556557
stdout = proc.stdout
557-
assert stdout is not None # noqa: S101
558+
assert stdout is not None
558559
stdout = _tee_to_stderr(stdout)
559560
try:
560561
async for line in stdout:
@@ -595,7 +596,7 @@ async def serve_uvicorn(
595596
env=_server_env(request),
596597
)
597598
stdout = proc.stdout
598-
assert stdout is not None # noqa: S101
599+
assert stdout is not None
599600
stdout = _tee_to_stderr(stdout)
600601
try:
601602
async for line in stdout:

pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -179,7 +179,7 @@ extend-ignore = [
179179
]
180180

181181
[tool.ruff.lint.per-file-ignores]
182-
"conformance/test/**" = ["ANN", "INP", "SLF", "SIM115", "D"]
182+
"conformance/test/**" = ["ANN", "INP", "SLF", "SIM115", "S101", "D"]
183183
"example/**" = [
184184
"ANN",
185185
"S", # Keep examples simpler, e.g. allow normal random

0 commit comments

Comments
 (0)