Use uvloop, raise ulimit on posix, and improve startup detection

Signed-off-by: Anuraag Agrawal <[email protected]>

Author: anuraaga

conformance/test/server.py

@@ -444,7 +444,7 @@ async def serve_granian(
     # so we need to determine it ourselves. If we see race conditions because of it,
     # we can set max-servers=1 in the runner.
     port = _find_free_port()
-    args = [f"--port={port}"]
+    args = [f"--port={port}", "--loop=uvloop"]
     if certfile:
         args.append(f"--ssl-certificate={certfile}")
     if keyfile:
@@ -473,7 +473,7 @@ async def serve_granian(
     try:
         for _ in range(100):
             line = await stdout.readline()
-            if b"Listening at:" in line:
+            if b"Started worker-1 runtime-1" in line:
                 break
         port_future.set_result(port)
         await proc.wait()
@@ -510,13 +510,20 @@ async def serve_gunicorn(
     )
     stdout = proc.stdout
     assert stdout is not None  # noqa: S101
+    port = None
     try:
         for _ in range(100):
             line = await stdout.readline()
             match = _port_regex.match(line.decode("utf-8"))
             if match:
-                port_future.set_result(int(match.group(1)))
+                port = int(match.group(1))
+                break
+            if b"Booting worker with pid" in line:
                 break
+        if port is None:
+            msg = "Could not determine port from gunicorn output"
+            raise RuntimeError(msg)
+        port_future.set_result(port)
         await proc.wait()
     except asyncio.CancelledError:
         proc.terminate()
@@ -531,7 +538,7 @@ async def serve_hypercorn(
     cafile: str | None,
     port_future: asyncio.Future[int],
 ):
-    args = ["--bind=localhost:0"]
+    args = ["--bind=localhost:0", "--worker-class=uvloop"]
     if certfile:
         args.append(f"--certfile={certfile}")
     if keyfile:

conformance/test/test_server.py

@@ -1,3 +1,4 @@
+import os
 import subprocess
 import sys
 from pathlib import Path
@@ -11,15 +12,17 @@
 _config_path = str(_current_dir / "config.yaml")
 
 
-# Servers often run out of file descriptors on macOS due to low default ulimit.
+# Servers often run out of file descriptors due to low default ulimit.
 # We go ahead and raise it automatically so tests can pass without special
 # configuration.
 @pytest.fixture(autouse=True, scope="session")
 def macos_raise_ulimit():
-    if sys.platform == "darwin":
-        import resource  # noqa: PLC0415
+    if os.name != "posix":
+        return
 
-        resource.setrlimit(resource.RLIMIT_NOFILE, (16384, 16384))
+    import resource  # noqa: PLC0415
+
+    resource.setrlimit(resource.RLIMIT_NOFILE, (16384, 16384))
 
 
 @pytest.mark.parametrize("server", ["granian", "gunicorn", "hypercorn"])

pyproject.toml

@@ -40,8 +40,8 @@ dev = [
     "brotli==1.1.0",
     "connect-python-example",
     "httpx[http2]==0.28.1",
-    "hypercorn==0.17.3",
-    "granian==2.5.5",
+    "hypercorn[uvloop]==0.17.3",
+    "granian[uvloop]==2.5.5",
     "gunicorn==23.0.0",
     "just-bin==1.42.4; sys_platform != 'win32'",
     "mkdocs==1.6.1",