Skip to content

Commit ed3130c

Browse files
committed
Revert and move otel dev dependencies to root with disclaimer
1 parent 1c83e31 commit ed3130c

File tree

5 files changed

+19
-12
lines changed

5 files changed

+19
-12
lines changed

DEVELOPMENT.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
2. Install dependencies:
2020

2121
```bash
22-
uv sync --all-packages
22+
uv sync
2323
```
2424

2525
## Development Workflow

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -405,7 +405,7 @@ We rely on the conformance test suit (in
405405
Set up a virtual env:
406406

407407
```sh
408-
uv sync --all-packages
408+
uv sync
409409
```
410410

411411
Then, use `uv run just` to do development checks, or check out `uv run just --list` for other targets.

connectrpc-otel/pyproject.toml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -63,10 +63,6 @@ dev = [
6363
# a transitive dependency, so we go ahead and leave it out.
6464
"connectrpc>=0.8.0",
6565

66-
"opentelemetry-instrumentation-asgi==0.61b0",
67-
"opentelemetry-instrumentation-wsgi==0.61b0",
68-
"opentelemetry-sdk==1.40.0",
69-
7066
"connect-python-example",
7167
"pytest",
7268
]

pyproject.toml

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,17 @@ dev = [
5757
"uvicorn==0.42.0",
5858
"zstandard==0.25.0",
5959

60+
# dev dependencies only used in subprojects. Optimal structure would include these
61+
# in the subproject itself, but then `uv sync` does not install them from the
62+
# workspace root. We strategically keep them here instead so the entire workspace
63+
# is ready for editing in an IDE with a simple sync command.
64+
# If the below issue is resolved, we can move them back to subprojects and configure
65+
# our default sync setting as --all-packages.
66+
# https://github.com/astral-sh/uv/issues/5737
67+
"opentelemetry-instrumentation-asgi==0.61b0",
68+
"opentelemetry-instrumentation-wsgi==0.61b0",
69+
"opentelemetry-sdk==1.40.0",
70+
6071
# Versions locked in constraint-dependencies
6172
"pytest",
6273
"pytest-asyncio",

uv.lock

Lines changed: 6 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)