♻️ Removes throwing from validator.

Removes the throwing capability of validator to avoid confusion with the returned result.

Author: connor-ricks

Sources/HTTPNetworking/Plugins/HTTPResponseValidator.swift

@@ -11,5 +11,5 @@ public typealias ValidationResult = Result<Void, Error>
 /// By conforming to ``HTTPResponseValidator`` you can implement both simple and complex logic for validating
 /// the response of an ``HTTPRequest``. Common use cases include validating the status code or headers of a response.
 public protocol HTTPResponseValidator {
-    func validate(_ response: HTTPURLResponse, for request: URLRequest, with data: Data) async throws -> ValidationResult
+    func validate(_ response: HTTPURLResponse, for request: URLRequest, with data: Data) async -> ValidationResult
 }

Sources/HTTPNetworking/Plugins/Validators/Validator.swift

@@ -4,7 +4,7 @@ public typealias ValidationHandler = (
     _ response: HTTPURLResponse,
     _ request: URLRequest,
     _ data: Data
-) async throws -> ValidationResult
+) async -> ValidationResult
 
 /// An ``HTTPResponseValidator`` that can be used to validate a response from an ``HTTPRequest``.
 public struct Validator: HTTPResponseValidator {
@@ -24,8 +24,8 @@ public struct Validator: HTTPResponseValidator {
 
     // MARK: HTTPResponseValidator
 
-    public func validate(_ response: HTTPURLResponse, for request: URLRequest, with data: Data) async throws -> ValidationResult {
-        try await handler(response, request, data)
+    public func validate(_ response: HTTPURLResponse, for request: URLRequest, with data: Data) async -> ValidationResult {
+        await handler(response, request, data)
     }
 }
 

Sources/HTTPNetworking/Plugins/Validators/ZipValidator.swift

@@ -28,11 +28,12 @@ public struct ZipValidator: HTTPResponseValidator {
 
     // MARK: ResponseValidator
 
-    public func validate(_ response: HTTPURLResponse, for request: URLRequest, with data: Data) async throws -> ValidationResult {
+    public func validate(_ response: HTTPURLResponse, for request: URLRequest, with data: Data) async -> ValidationResult {
         for validator in validators {
-            try Task.checkCancellation()
+            do { try Task.checkCancellation() }
+            catch { return .failure(error) }
 
-            if case .failure(let error) = try await validator.validate(response, for: request, with: data) {
+            if case .failure(let error) = await validator.validate(response, for: request, with: data) {
                 return .failure(error)
             }
         }

Tests/HTTPNetworkingTests/HTTPRequestTests.swift

@@ -624,7 +624,7 @@ class HTTPRequestTests: XCTestCase {
             ]),
             validators: [
                 Validator { _, _, _ in
-                    throw expectedError
+                    .failure(expectedError)
                 }
             ]
         )
@@ -652,7 +652,7 @@ class HTTPRequestTests: XCTestCase {
             _ = try await client
                 .request(for: .get, to: url, expecting: [String].self)
                 .validate { _, _, _ in
-                    throw expectedError
+                    .failure(expectedError)
                 }
                 .run()
         } catch {