Skip to content

Commit 63b1231

Browse files
committed
Some README TODOs
1 parent 130619f commit 63b1231

File tree

1 file changed

+9
-3
lines changed

1 file changed

+9
-3
lines changed

README.md

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ $client->read('res.partner', [17858, 17852])->value()->me['array']
8383
```
8484

8585
If you have specific requirements for the XML-RPC client, such as an SSL
86-
certificate to add, then yiu can get the client instance using:
86+
certificate to add, then you can get the client instance using:
8787

8888
$xmlRpcClient = $client->getXmlRpcClient($type);
8989

@@ -93,7 +93,7 @@ You have the ability to construct your own messages from scratch like this,
9393
and there are helper methods in the `$client` to convert native PHP data types
9494
to and from XML RPC value objects.
9595
However, you should be able to leave all that conversion to be handled in the
96-
background by the client - just give it array/string/in/etc. data and get
96+
background by the client - just give it array/string/int/etc. data and get
9797
models and arrays back.
9898

9999
# Query methods
@@ -160,7 +160,7 @@ $response = $client->write(
160160

161161
# TODO
162162

163-
* Conversion of date types has not been tested.
163+
* Conversion of `date` types have not been tested.
164164
Ideally we would support Carbon 2 for sending dates in and getting
165165
dates back out again.
166166
* Tests. It's always the tests that get left behind when time gets in
@@ -169,4 +169,10 @@ $response = $client->write(
169169
* Would be nice to split this up into a non-laravel package and then
170170
add a separate laravel wrapper for it. But collections are just too
171171
nice, so this may not happen.
172+
* Helper methods for some of the Odoo version specific data structures.
173+
For example, specifying the list of fields to retrieve for a `read`
174+
has new structures introduced for versions 7, 8 and 10.
175+
The client class is also going to star getting a bit cumbersome at this
176+
point, so moving some of the XML-RPC sepcific stuff (message creation, data
177+
conversion) would be best moved to a separate connction class).
172178

0 commit comments

Comments
 (0)