Ensure Ctrl+Click navigates to the definition in the same file (#33)

* Fix unified definition navigation and Ctrl+Click local resolution

* Fix removed custom Go to Definition command from editor title actions to hide the top bar button

* Revert "Fix unified definition navigation and Ctrl+Click local resolution"
This reverts commit ce01489.

* Ensure Ctrl+Click navigates to the definition in the same file

Author: LeoAnders

src/ccs/providers/DefinitionDocumentLinkProvider.ts

@@ -48,7 +48,8 @@ export class DefinitionDocumentLinkProvider implements vscode.DocumentLinkProvid
     );
 
     return queries.map((match) => {
-      const args = [document.uri.toString(), match.range.start.line, match.range.start.character];
+      const targetPosition = this.getDefinitionPosition(match.range);
+      const args = [document.uri.toString(), targetPosition.line, targetPosition.character];
       const commandUri = vscode.Uri.parse(
         `command:${followDefinitionLinkCommand}?${encodeURIComponent(JSON.stringify(args))}`
       );
@@ -58,6 +59,15 @@ export class DefinitionDocumentLinkProvider implements vscode.DocumentLinkProvid
     });
   }
 
+  private getDefinitionPosition(range: vscode.Range): vscode.Position {
+    const { start, end } = range;
+    if (end.isAfter(start)) {
+      const character = Math.max(start.character, end.character - 1);
+      return new vscode.Position(start.line, character);
+    }
+    return start;
+  }
+
   public dispose(): void {
     for (const timeout of this.refreshTimeouts.values()) {
       clearTimeout(timeout);