Skip to content

Commit 03734cc

Browse files
Try to fix remaining problems
1 parent 16c8f20 commit 03734cc

File tree

3 files changed

+28
-31
lines changed

3 files changed

+28
-31
lines changed

cluster_tools/lifted_multicut/reduce_lifted_problem.py

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -150,17 +150,16 @@ def _merge_nodes(problem_path, scale, blocking,
150150
initial_node_labeling, n_threads):
151151
# load the cut edge ids
152152
n_edges = len(uv_ids)
153-
cut_edge_ids = _load_cut_edges(problem_path, scale, blocking,
154-
block_list, n_threads)
155-
assert len(cut_edge_ids) < n_edges, "%i = %i, does not reduce problem" % (len(cut_edge_ids),
156-
n_edges)
153+
cut_edge_ids = _load_cut_edges(problem_path, scale, blocking, block_list, n_threads)
154+
assert len(cut_edge_ids) < n_edges, "%i = %i, does not reduce problem" % (len(cut_edge_ids), n_edges)
157155

158156
merge_edges = np.ones(n_edges, dtype="bool")
159157
merge_edges[cut_edge_ids] = False
160158
fu.log("merging %i / %i edges" % (np.sum(merge_edges), n_edges))
161159

162160
# merge node pairs with ufd
163-
ufd = nufd.boost_ufd(nodes)
161+
n_nodes = int(nodes.max()) + 1
162+
ufd = nufd.ufd(n_nodes)
164163
ufd.merge(uv_ids[merge_edges])
165164

166165
# get the node results and label them consecutively

cluster_tools/multicut/reduce_problem.py

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -150,21 +150,20 @@ def _merge_nodes(problem_path, scale, blocking,
150150
n_edges = len(uv_ids)
151151
cut_edge_ids = _load_cut_edges(problem_path, scale, blocking,
152152
block_list, n_threads)
153-
assert len(cut_edge_ids) < n_edges, "%i = %i, does not reduce problem" % (len(cut_edge_ids),
154-
n_edges)
153+
assert len(cut_edge_ids) < n_edges, "%i = %i, does not reduce problem" % (len(cut_edge_ids), n_edges)
155154

156155
merge_edges = np.ones(n_edges, dtype='bool')
157156
merge_edges[cut_edge_ids] = False
158157
fu.log('merging %i / %i edges' % (np.sum(merge_edges), n_edges))
159158

160159
# merge node pairs with ufd
161-
ufd = nufd.boost_ufd(nodes)
160+
n_nodes = int(nodes.max()) + 1
161+
ufd = nufd.ufd(n_nodes)
162162
ufd.merge(uv_ids[merge_edges])
163163

164164
# get the node results and label them consecutively
165165
node_labeling = ufd.find(nodes)
166-
node_labeling, max_new_id, _ = relabelConsecutive(node_labeling, start_label=0,
167-
keep_zeros=False)
166+
node_labeling, max_new_id, _ = relabelConsecutive(node_labeling, start_label=0, keep_zeros=False)
168167
assert node_labeling[0] == 0
169168
# FIXME this looks fishy, redo !!!
170169
# # make sure that zero is still mapped to zero

run_all_tests.sh

Lines changed: 20 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -110,16 +110,16 @@ then
110110
exit 1
111111
fi
112112

113-
# python test/mutex_watershed/test_mws.py
114-
# if [[ $? != 0 ]]
115-
# then
116-
# exit 1
117-
# fi
118-
# python test/mutex_watershed/test_mws_with_mask.py
119-
# if [[ $? != 0 ]]
120-
# then
121-
# exit 1
122-
# fi
113+
python test/mutex_watershed/test_mws.py
114+
if [[ $? != 0 ]]
115+
then
116+
exit 1
117+
fi
118+
python test/mutex_watershed/test_mws_with_mask.py
119+
if [[ $? != 0 ]]
120+
then
121+
exit 1
122+
fi
123123

124124
python test/node_labels/test_node_labels.py
125125
if [[ $? != 0 ]]
@@ -185,17 +185,16 @@ then
185185
exit 1
186186
fi
187187

188-
# The "ReduceProblem" task hangs for both these tests.
189-
# python test/workflows/lifted_multicut_workflow.py
190-
# if [[ $? != 0 ]]
191-
# then
192-
# exit 1
193-
# fi
194-
# python test/workflows/multicut_workflow.py
195-
# if [[ $? != 0 ]]
196-
# then
197-
# exit 1
198-
# fi
188+
python test/workflows/lifted_multicut_workflow.py
189+
if [[ $? != 0 ]]
190+
then
191+
exit 1
192+
fi
193+
python test/workflows/multicut_workflow.py
194+
if [[ $? != 0 ]]
195+
then
196+
exit 1
197+
fi
199198

200199
python test/write/test_write.py
201200
if [[ $? != 0 ]]

0 commit comments

Comments
 (0)