Skip to content

Commit 2241142

Browse files
Remove docker folder and update build documentation
- Remove docker/ directory as it's no longer needed - Update README.md to remove Docker prerequisites and references - Simplify package.json wasm:make script to use emmake directly - Remove docker exclusion from .npmignore - All 32 tests passing, confirming functionality intact Co-Authored-By: Dan Lynch <[email protected]>
1 parent 23e8602 commit 2241142

File tree

5 files changed

+6
-83
lines changed

5 files changed

+6
-83
lines changed

.npmignore

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ test
44
.travis.yml
55
package.json
66
build
7-
docker
7+
88
libpg_query/**/*.a
99
libpg_query/**/*.h
1010

README.md

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -208,8 +208,6 @@ This package uses a **WASM-only build system** for true cross-platform compatibi
208208
### Prerequisites
209209

210210
- Node.js (version 16 or higher recommended)
211-
- Docker (for WASM compilation using Emscripten)
212-
- yarn or npm
213211

214212
### Building WASM Artifacts
215213

@@ -236,7 +234,7 @@ This package uses a **WASM-only build system** for true cross-platform compatibi
236234
### Build Process Details
237235

238236
The WASM build process:
239-
- Uses Docker with Emscripten SDK for compilation
237+
- Uses Emscripten SDK for compilation
240238
- Compiles C wrapper code to WebAssembly
241239
- Generates `wasm/libpg-query.js` and `wasm/libpg-query.wasm` files
242240
- No native compilation or node-gyp dependencies required
@@ -288,9 +286,9 @@ Our latest is built with `17-latest` branch from libpg_query
288286
- Ensure you call an async method first to initialize the WASM module
289287
- Or use the async versions of methods which handle initialization automatically
290288

291-
**Docker permission errors:**
292-
- Ensure Docker is running and accessible
293-
- On Linux, you may need to add your user to the docker group
289+
**Build environment issues:**
290+
- Ensure Emscripten SDK is properly installed and configured
291+
- Check that all required build dependencies are available
294292

295293
### Build Artifacts
296294

docker/Dockerfile

Lines changed: 0 additions & 8 deletions
This file was deleted.

docker/readme.md

Lines changed: 0 additions & 67 deletions
This file was deleted.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
},
3030
"scripts": {
3131
"clean": "rimraf build",
32-
"wasm:make": "docker run --rm -v $(pwd):/src -u $(id -u):$(id -g) emscripten/emsdk emmake make",
32+
"wasm:make": "emmake make",
3333
"wasm:build": "yarn wasm:make build",
3434
"wasm:rebuild": "yarn wasm:make rebuild",
3535
"wasm:clean": "yarn wasm:make clean",

0 commit comments

Comments
 (0)