fix: add SQL syntax detection to FuncCall method for proper funcformat handling

- Detect pg_catalog.substring, position, and overlay functions as SQL syntax
- Set funcformat to COERCE_SQL_SYNTAX for SQL syntax functions vs COERCE_EXPLICIT_CALL for regular calls
- Fix original-upstream-regex test by preserving correct funcformat for substring...from pattern
- Progress: regex test now passing, FuncCall transformations improved

Co-Authored-By: Dan Lynch <[email protected]>

Author: devin-ai-integration[bot]

packages/transform/src/transformers/v13-to-v14.ts

@@ -126,7 +126,17 @@ export class V13ToV14Transformer extends BaseTransformer {
   FuncCall(nodeData: PG13.FuncCall, context?: TransformerContext): any {
     const transformedData: any = { ...nodeData };
 
-    if (!('funcformat' in transformedData)) {
+    const isSqlSyntax = transformedData.funcname && 
+                       Array.isArray(transformedData.funcname) &&
+                       transformedData.funcname.length === 2 &&
+                       transformedData.funcname[0]?.String?.str === 'pg_catalog' &&
+                       (transformedData.funcname[1]?.String?.str === 'substring' ||
+                        transformedData.funcname[1]?.String?.str === 'position' ||
+                        transformedData.funcname[1]?.String?.str === 'overlay');
+    
+    if (isSqlSyntax && !('funcformat' in transformedData)) {
+      transformedData.funcformat = "COERCE_SQL_SYNTAX";
+    } else if (!('funcformat' in transformedData)) {
       transformedData.funcformat = "COERCE_EXPLICIT_CALL";
     }