Skip to content

Commit 133606b

Browse files
committed
Update STATUS-15-16.md with current test progress
- Corrected test count to 194 passing tests (64 failed, 258 total) - Documented stable baseline after reverting INSERT transformation logic - Updated analysis of remaining failing tests patterns Co-Authored-By: Dan Lynch <[email protected]>
1 parent b9e9963 commit 133606b

File tree

1 file changed

+9
-9
lines changed

1 file changed

+9
-9
lines changed

β€Žpackages/transform/STATUS-15-16.mdβ€Ž

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
# PostgreSQL v15-to-v16 AST Transformer Status
22

33
## Current Status: **IN PROGRESS** 🟑
4-
- **Test Pass Rate**: 193/258 tests passing (74.8% success rate)
4+
- **Test Pass Rate**: 194/258 tests passing (75.2% success rate)
55
- **Branch**: `transform/pg15-pg16`
66
- **PR**: [#182](https://github.com/launchql/pgsql-parser/pull/182)
77

88
## Progress Summary
9-
Started from a basic skeleton transformer and systematically implemented node wrapping and transformation logic across all node types. Made significant progress improving test pass rate from initial ~30% to current 74.8%.
9+
Started from a basic skeleton transformer and systematically implemented node wrapping and transformation logic across all node types. Made significant progress improving test pass rate from initial ~30% to current 75.2%.
1010

1111
## Key Achievements
1212
- βœ… Implemented comprehensive node transformation methods for 100+ node types
@@ -16,18 +16,18 @@ Started from a basic skeleton transformer and systematically implemented node wr
1616
- βœ… Implemented context-aware Integer transformation logic for DefineStmt contexts
1717
- βœ… Added GrantRoleStmt admin_opt to opt field transformation
1818

19-
## Current Challenge: Remaining 65 Failing Tests
20-
**Root Issue**: Successfully resolved over-transformation and under-transformation issues for Integer objects. Maintained stable baseline of 193 passing tests after reverting INSERT transformation logic that caused regressions.
19+
## Current Challenge: Remaining 64 Failing Tests
20+
**Root Issue**: Successfully resolved over-transformation and under-transformation issues for Integer objects. Maintained stable baseline of 194 passing tests after reverting INSERT transformation logic that caused regressions.
2121

2222
**Analysis Completed**:
2323
- βœ… Fixed over-transformation: A_Const ival transformation now conservative, only transforms in specific DefineStmt contexts
2424
- βœ… Fixed under-transformation: Added TypeName arrayBounds and DefineStmt args contexts to Integer method
2525
- βœ… Empty Integer objects in TypeName arrayBounds context now transform to `{"ival": -1}`
2626
- βœ… Empty Integer objects in DefineStmt args context now transform to `{"ival": -1}`
27-
- βœ… Reverted INSERT transformation logic to prevent regressions from 193 to 184 passing tests
28-
- πŸ”„ Need to continue systematic improvement of remaining 65 failing tests
27+
- βœ… Reverted INSERT transformation logic to prevent regressions from 194 to 184 passing tests
28+
- πŸ”„ Need to continue systematic improvement of remaining 64 failing tests
2929

30-
## Failing Tests (65 total)
30+
## Failing Tests (64 total)
3131

3232
### Latest PostgreSQL Tests (9 tests)
3333
- [ ] latest/postgres/create_aggregate-6.sql
@@ -126,8 +126,8 @@ Started from a basic skeleton transformer and systematically implemented node wr
126126
5. Continue systematic improvement of remaining failing tests
127127

128128
## Test Categories
129-
- **Passing (193)**: Basic node transformations, most SQL constructs, Integer transformations in TypeName and DefineStmt contexts
130-
- **Failing (65)**: Complex nested structures, remaining transformation edge cases, INSERT VALUES contexts
129+
- **Passing (194)**: Basic node transformations, most SQL constructs, Integer transformations in TypeName and DefineStmt contexts
130+
- **Failing (64)**: Complex nested structures, remaining transformation edge cases, INSERT VALUES contexts
131131

132132
## Technical Notes
133133
- Following patterns from v14-to-v15 transformer as reference

0 commit comments

Comments
Β (0)