fix: remove automatic inh field addition from BaseTransformer

devin-ai-integration[bot] · pyramation · devin-ai-integration[bot] · commit 2c6fcb896f79 · 2025-06-25T02:26:04.000Z
- Remove automatic inh: true addition for RangeVar nodes in ensureCriticalFields
- Remove automatic inh: true addition for relation fields in ensureCriticalFields
- Fix original-upstream-inherit test by preserving original inheritance behavior
- Ensure ONLY keyword tables don't incorrectly get inh: true added
- Progress: inherit test now passing, field preservation improved

Co-Authored-By: Dan Lynch &lt;pyramation@gmail.com&gt;
diff --git a/packages/transform/src/visitors/base.ts b/packages/transform/src/visitors/base.ts
@@ -88,9 +88,6 @@ export abstract class BaseTransformer implements TransformerVisitor {
       if (!('relpersistence' in nodeData)) {
         nodeData.relpersistence = 'p';
       }
-      if (!('inh' in nodeData)) {
-        nodeData.inh = true;
-      }
     }
 
     if (nodeType === 'TypeName') {
@@ -103,9 +100,6 @@ export abstract class BaseTransformer implements TransformerVisitor {
       if (!('relpersistence' in nodeData.relation)) {
         nodeData.relation.relpersistence = 'p';
       }
-      if (!('inh' in nodeData.relation)) {
-        nodeData.relation.inh = true;
-      }
     }
 
     if (nodeData.typeName && typeof nodeData.typeName === 'object') {

Original file line number	Diff line number	Diff line change
`@@ -88,9 +88,6 @@ export abstract class BaseTransformer implements TransformerVisitor {`
`88`	`88`	`if (!('relpersistence' in nodeData)) {`
`89`	`89`	`nodeData.relpersistence = 'p';`
`90`	`90`	`}`
`91`		`- if (!('inh' in nodeData)) {`
`92`		`- nodeData.inh = true;`
`93`		`- }`
`94`	`91`	`}`
`95`	`92`
`96`	`93`	`if (nodeType === 'TypeName') {`
`@@ -103,9 +100,6 @@ export abstract class BaseTransformer implements TransformerVisitor {`
`103`	`100`	`if (!('relpersistence' in nodeData.relation)) {`
`104`	`101`	`nodeData.relation.relpersistence = 'p';`
`105`	`102`	`}`
`106`		`- if (!('inh' in nodeData.relation)) {`
`107`		`- nodeData.relation.inh = true;`
`108`		`- }`
`109`	`103`	`}`
`110`	`104`
`111`	`105`	`if (nodeData.typeName && typeof nodeData.typeName === 'object') {`