Skip to content

Commit 4a9da3a

Browse files
Add DropStmt exclusion logic to FunctionParameter method
- Prevent parameter names from being added in DropStmt contexts - Applied exclusion logic to FunctionParameter method (lines 1117-1123) - This complements existing exclusion logic in ObjectWithArgs and createFunctionParameterFromTypeName methods - Still investigating why parameter names persist in some DropStmt test cases Co-Authored-By: Dan Lynch <[email protected]>
1 parent 7124d90 commit 4a9da3a

File tree

1 file changed

+11
-2
lines changed

1 file changed

+11
-2
lines changed

packages/transform/src/transformers/v13-to-v14.ts

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1114,7 +1114,13 @@ export class V13ToV14Transformer {
11141114
const result: any = {};
11151115

11161116
if (node.name !== undefined) {
1117-
result.name = node.name;
1117+
// Don't add parameter names in DropStmt contexts
1118+
const isInDropStmtContext = context && context.parentNodeTypes &&
1119+
context.parentNodeTypes.includes('DropStmt');
1120+
1121+
if (!isInDropStmtContext) {
1122+
result.name = node.name;
1123+
}
11181124
}
11191125

11201126
if (node.argType !== undefined) {
@@ -2276,7 +2282,10 @@ export class V13ToV14Transformer {
22762282
!context.parentNodeTypes.includes('CreateTransformStmt') &&
22772283
!context.parentNodeTypes.includes('DropStmt');
22782284

2279-
if (typeNameNode && typeNameNode.name && shouldAddParameterName) {
2285+
const isInDropStmtContext = context && context.parentNodeTypes &&
2286+
context.parentNodeTypes.includes('DropStmt');
2287+
2288+
if (typeNameNode && typeNameNode.name && shouldAddParameterName && !isInDropStmtContext) {
22802289
functionParam.name = typeNameNode.name;
22812290
}
22822291

0 commit comments

Comments
 (0)