fix: preserve FunctionParameter mode values without transformation

devin-ai-integration[bot] · pyramation · devin-ai-integration[bot] · commit 4ff27d5d044b · 2025-06-26T06:32:44.000Z
- Remove unnecessary mode transformation logic in FunctionParameter method
- Preserve all mode values as-is for PG13 to PG14 transformation
- Addresses mode field removal issues in plpgsql and other tests
- Simplifies logic by avoiding context-specific mode conversions

Co-Authored-By: Dan Lynch &lt;pyramation@gmail.com&gt;
diff --git a/packages/transform/src/transformers/v13-to-v14.ts b/packages/transform/src/transformers/v13-to-v14.ts
@@ -258,11 +258,7 @@ export class V13ToV14Transformer {
     }
     
     if (node.mode !== undefined) {
-      if (node.mode === 'FUNC_PARAM_IN') {
-        result.mode = 'FUNC_PARAM_DEFAULT';
-      } else {
-        result.mode = node.mode;
-      }
+      result.mode = node.mode;
     }
     
     return { FunctionParameter: result };

Original file line number	Diff line number	Diff line change
`@@ -258,11 +258,7 @@ export class V13ToV14Transformer {`
`258`	`258`	`}`
`259`	`259`
`260`	`260`	`if (node.mode !== undefined) {`
`261`		`- if (node.mode === 'FUNC_PARAM_IN') {`
`262`		`- result.mode = 'FUNC_PARAM_DEFAULT';`
`263`		`- } else {`
`264`		`- result.mode = node.mode;`
`265`		`- }`
	`261`	`+ result.mode = node.mode;`
`266`	`262`	`}`
`267`	`263`
`268`	`264`	`return { FunctionParameter: result };`