Remove isNode field from FieldSpec interface and update runtime schema system

- Remove isNode field from FieldSpec interface in runtime-schema/types.ts
- Update runtime schema generator to not include isNode in FieldSpec objects
- Remove isNode field from NodeSpec interface in both types.ts and store.ts
- Update generateRuntimeSchemaTypeScript method to match new interface
- Fix logic in generateTsAstCodeFromPgAstWithSchema to determine node wrapping by checking field type directly
- Update README documentation to reflect schema changes
- All tests now pass with the simplified schema structure

Co-Authored-By: Dan Lynch <[email protected]>

Author: devin-ai-integration[bot]

packages/proto-parser/src/runtime-schema/README.md

@@ -8,7 +8,7 @@ The runtime schema system extracts metadata from protobuf definitions to create
 - All AST node types and their structure
 - Which types are wrapped (listed in Node.oneof)
 - Field specifications including type, optionality, and array status
-- Node field detection for AST references
+- Node type detection based on field type information
 
 ## Usage
 
@@ -62,12 +62,13 @@ Each field within a node is represented by a FieldSpec:
 interface FieldSpec {
   name: string;        // field name
   type: string;        // field type (e.g. "RangeVar", "string", "Node")
-  isNode: boolean;     // true if field references AST nodes
   isArray: boolean;    // true if field is repeated
   optional: boolean;   // true if field is optional
 }
 ```
 
+To determine if a field references AST nodes, check if the `type` is a specific node type (exists in the runtime schema) rather than the generic "Node" type.
+
 ## CLI Tool
 
 A CLI tool is available for generating runtime schemas:

packages/proto-parser/src/runtime-schema/generator.ts

@@ -53,7 +53,6 @@ export class RuntimeSchemaGenerator {
 
     return {
       name: type.name,
-      isNode: this.nodeTypes.has(type.name),
       fields: fields.sort((a, b) => a.name.localeCompare(b.name))
     };
   }
@@ -63,12 +62,10 @@ export class RuntimeSchemaGenerator {
     const isArray = field.repeated || false;
     const optional = !field.required;
     const fieldType = field.type;
-    const isNode = fieldType === 'Node' || this.nodeTypes.has(fieldType);
 
     return {
       name: fieldName,
       type: fieldType,
-      isNode,
       isArray,
       optional
     };

packages/proto-parser/src/runtime-schema/types.ts

@@ -1,14 +1,12 @@
 export interface FieldSpec {
   name: string;
   type: string;
-  isNode: boolean;
   isArray: boolean;
   optional: boolean;
 }
 
 export interface NodeSpec {
   name: string;
-  isNode: boolean;
   fields: FieldSpec[];
 }
 

packages/proto-parser/src/store.ts

@@ -275,14 +275,12 @@ export class ProtoStore implements IProtoStore {
       'export interface FieldSpec {',
       '  name: string;',
       '  type: string;',
-      '  isNode: boolean;',
       '  isArray: boolean;',
       '  optional: boolean;',
       '}',
       '',
       'export interface NodeSpec {',
       '  name: string;',
-      '  isNode: boolean;',
       '  fields: FieldSpec[];',
       '}',
       ''

packages/proto-parser/src/utils/meta.ts

@@ -147,7 +147,7 @@ export function generateTsAstCodeFromPgAstWithSchema(ast: any, runtimeSchema: No
                     const parentSpec = schemaMap.get(parentNodeType);
                     if (parentSpec) {
                         const fieldSpec = parentSpec.fields.find(f => f.name === fieldName);
-                        if (fieldSpec && fieldSpec.isNode && fieldSpec.type !== 'Node') {
+                        if (fieldSpec && fieldSpec.type !== 'Node' && schemaMap.has(fieldSpec.type)) {
                             isWrapped = false;
                         }
                     }
@@ -170,7 +170,7 @@ export function generateTsAstCodeFromPgAstWithSchema(ast: any, runtimeSchema: No
                         const parentSpec = schemaMap.get(parentNodeType);
                         if (parentSpec) {
                             const parentFieldSpec = parentSpec.fields.find(f => f.name === fieldName);
-                            if (parentFieldSpec && parentFieldSpec.isNode && parentFieldSpec.type !== 'Node') {
+                            if (parentFieldSpec && parentFieldSpec.type !== 'Node' && schemaMap.has(parentFieldSpec.type)) {
                                 isWrapped = false;
                             }
                         }