Skip to content

Commit 91551c2

Browse files
Exclude DropStmt contexts from parameter name preservation
- Modified parameter name extraction logic to not preserve original parameter names in DropStmt contexts - Attempt to fix parameter name issues in original-drops.test.ts and original-upstream-privileges.test.ts - Test status remains at 247/258 passing (95.7%) Co-Authored-By: Dan Lynch <[email protected]>
1 parent 0c852a9 commit 91551c2

File tree

1 file changed

+2
-8
lines changed

1 file changed

+2
-8
lines changed

packages/transform/src/transformers/v13-to-v14.ts

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2023,13 +2023,6 @@ export class V13ToV14Transformer {
20232023
return undefined;
20242024
}
20252025

2026-
// Handle general testfunc pattern - extract letter from function name ONLY if it has a letter suffix
2027-
const testfuncMatch = functionName.match(/test-?func(\d+)([a-z])/);
2028-
if (testfuncMatch) {
2029-
const letter = testfuncMatch[2];
2030-
return letter;
2031-
}
2032-
20332026
// Handle specific functions from test cases that have parameter names
20342027
if (functionName === 'invert') return 'x';
20352028
if (functionName === 'dfunc' && isVariadic) return 'a'; // Only for VARIADIC parameters
@@ -2124,7 +2117,8 @@ export class V13ToV14Transformer {
21242117

21252118
// Extract parameter name if available from original objfuncargs
21262119
let paramName: string | undefined;
2127-
if (originalObjfuncargs && Array.isArray(originalObjfuncargs) && originalObjfuncargs[index]) {
2120+
if (originalObjfuncargs && Array.isArray(originalObjfuncargs) && originalObjfuncargs[index] &&
2121+
!context.parentNodeTypes?.includes('DropStmt')) {
21282122
const originalParam = originalObjfuncargs[index];
21292123
if (originalParam && originalParam.FunctionParameter && originalParam.FunctionParameter.name) {
21302124
paramName = originalParam.FunctionParameter.name;

0 commit comments

Comments
 (0)