fix: resolve ParseResult traversal and context path issues

- Fix ParseResult nodes test by implementing proper recursive traversal in visit function
- Correct context path generation to exclude node type names
- All 10 tests now pass locally
- Maintain backward compatibility with legacy visit API

Co-Authored-By: Dan Lynch <[email protected]>

Author: devin-ai-integration[bot]

packages/traverse/__test__/traverse.test.ts

@@ -194,13 +194,17 @@ describe('traverse', () => {
   it('should handle ParseResult nodes', () => {
     const parseResultVisited: any[] = [];
     const rawStmtVisited: any[] = [];
+    const selectStmtVisited: any[] = [];
 
     const visitor = {
       ParseResult: (node: any, ctx: any) => {
         parseResultVisited.push({ node, ctx });
       },
       RawStmt: (node: any, ctx: any) => {
         rawStmtVisited.push({ node, ctx });
+      },
+      SelectStmt: (node: any, ctx: any) => {
+        selectStmtVisited.push({ node, ctx });
       }
     };
 
@@ -227,6 +231,10 @@ describe('traverse', () => {
 
     expect(parseResultVisited).toHaveLength(1);
     expect(rawStmtVisited).toHaveLength(1);
+    expect(selectStmtVisited).toHaveLength(1);
+    expect(parseResultVisited[0].node.version).toBe(170004);
+    expect(rawStmtVisited[0].node.stmt).toBeDefined();
+    expect(selectStmtVisited[0].node.limitOption).toBe('LIMIT_OPTION_DEFAULT');
   });
 
   it('should provide correct visitor context', () => {

packages/traverse/src/traverse.ts

@@ -114,18 +114,34 @@ export function visit(
   visitor: { [key: string]: (node: any, ctx: VisitorContext) => void },
   ctx: VisitorContext = { path: [], parent: null, key: '' }
 ): void {
-  const legacyVisitor: Visitor = {};
-  
-  for (const [nodeType, visitFn] of Object.entries(visitor)) {
-    legacyVisitor[nodeType] = (path: NodePath) => {
-      const legacyCtx: VisitorContext = {
-        path: path.path,
-        parent: path.parent?.node || null,
-        key: path.key
-      };
-      visitFn(path.node, legacyCtx);
-    };
+  if (node == null || typeof node !== 'object') return;
+
+  const nodeType = Object.keys(node)[0] as string;
+  const nodeData = node[nodeType];
+
+  const visitFn = visitor[nodeType];
+  if (visitFn) {
+    visitFn(nodeData, ctx);
+  }
+
+  for (const key in nodeData) {
+    const value = (nodeData as any)[key];
+    if (Array.isArray(value)) {
+      value.forEach((item, index) => {
+        if (typeof item === 'object' && item !== null && Object.keys(item).length === 1) {
+          visit(item, visitor, {
+            parent: value,
+            key: index,
+            path: [...ctx.path, key, index],
+          });
+        }
+      });
+    } else if (typeof value === 'object' && value !== null && Object.keys(value).length === 1) {
+      visit(value, visitor, {
+        parent: nodeData,
+        key,
+        path: [...ctx.path, key],
+      });
+    }
   }
-  
-  walk(node, legacyVisitor);
 }