Skip to content

Commit f92d5d1

Browse files
Update STATUS-15-16.md to reflect stable 194 passing tests baseline
- Document stable baseline of 194 passing tests (75.2% success rate) - Update analysis to reflect multiple attempts at FuncCall transformation causing regressions - Revise next steps to focus on targeted, conservative fixes - Emphasize maintaining 194 passing tests baseline while incrementally improving Co-Authored-By: Dan Lynch <[email protected]>
1 parent 0dcf046 commit f92d5d1

File tree

1 file changed

+11
-10
lines changed

1 file changed

+11
-10
lines changed

β€Žpackages/transform/STATUS-15-16.mdβ€Ž

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# PostgreSQL v15-to-v16 AST Transformer Status
22

33
## Current Status: **IN PROGRESS** 🟑
4-
- **Test Pass Rate**: 194/258 tests passing (75.2% success rate)
4+
- **Test Pass Rate**: 194/258 tests passing (75.2% success rate) - **STABLE BASELINE**
55
- **Branch**: `transform/pg15-pg16`
66
- **PR**: [#182](https://github.com/launchql/pgsql-parser/pull/182)
77

@@ -17,15 +17,16 @@ Started from a basic skeleton transformer and systematically implemented node wr
1717
- βœ… Added GrantRoleStmt admin_opt to opt field transformation
1818

1919
## Current Challenge: Remaining 64 Failing Tests
20-
**Root Issue**: Successfully resolved over-transformation and under-transformation issues for Integer objects. Maintained stable baseline of 194 passing tests after reverting INSERT transformation logic that caused regressions.
20+
**Root Issue**: Successfully established stable baseline of 194 passing tests with conservative Integer transformation logic. Multiple attempts to add FuncCall context transformation caused regressions, indicating need for more targeted approach.
2121

2222
**Analysis Completed**:
23-
- βœ… Fixed over-transformation: A_Const ival transformation now conservative, only transforms in specific DefineStmt contexts
23+
- βœ… Fixed over-transformation: A_Const ival transformation now conservative, only transforms in specific contexts
2424
- βœ… Fixed under-transformation: Added TypeName arrayBounds and DefineStmt args contexts to Integer method
2525
- βœ… Empty Integer objects in TypeName arrayBounds context now transform to `{"ival": -1}`
2626
- βœ… Empty Integer objects in DefineStmt args context now transform to `{"ival": -1}`
27-
- βœ… Reverted INSERT transformation logic to prevent regressions from 194 to 184 passing tests
28-
- πŸ”„ Need to continue systematic improvement of remaining 64 failing tests
27+
- βœ… Reverted INSERT and FuncCall transformation logic to prevent regressions
28+
- βœ… Maintained stable baseline of 194 passing tests through multiple iterations
29+
- πŸ”„ Need systematic analysis of remaining 64 failing tests without causing regressions
2930

3031
## Failing Tests (64 total)
3132

@@ -119,11 +120,11 @@ Started from a basic skeleton transformer and systematically implemented node wr
119120
- Multiple analysis scripts for specific failing test patterns
120121

121122
## Next Steps
122-
1. Fix DefineStmt method to pass proper context for args transformation
123-
2. Ensure empty Integer objects in DefineStmt args context transform to `{"ival": -1}`
124-
3. Test the fix against the specific failing CREATE AGGREGATE case
125-
4. Run full test suite to verify improvements
126-
5. Continue systematic improvement of remaining failing tests
123+
1. Analyze specific failing test patterns without broad transformation approaches
124+
2. Identify minimal, targeted fixes that don't affect the 194 passing tests
125+
3. Focus on individual failing test cases to understand precise transformation requirements
126+
4. Implement extremely conservative fixes that only address specific edge cases
127+
5. Maintain 194 passing tests baseline while incrementally improving failing tests
127128

128129
## Test Categories
129130
- **Passing (194)**: Basic node transformations, most SQL constructs, Integer transformations in TypeName and DefineStmt contexts

0 commit comments

Comments
Β (0)