Skip to content

Commit 7061dc2

Browse files
authored
Merge pull request #309 from saad-ali/removeNodeGetId
Remove deprecated `NodeGetId` before 1.0
2 parents a859ccf + a8170a7 commit 7061dc2

File tree

3 files changed

+274
-456
lines changed

3 files changed

+274
-456
lines changed

csi.proto

Lines changed: 0 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -67,20 +67,9 @@ service Node {
6767
rpc NodeGetVolumeStats (NodeGetVolumeStatsRequest)
6868
returns (NodeGetVolumeStatsResponse) {}
6969

70-
// NodeGetId is being deprecated in favor of NodeGetInfo and will be
71-
// removed in CSI 1.0. Existing drivers, however, may depend on this
72-
// RPC call and hence this RPC call MUST be implemented by the CSI
73-
// plugin prior to v1.0.
74-
rpc NodeGetId (NodeGetIdRequest)
75-
returns (NodeGetIdResponse) {
76-
option deprecated = true;
77-
}
78-
7970
rpc NodeGetCapabilities (NodeGetCapabilitiesRequest)
8071
returns (NodeGetCapabilitiesResponse) {}
8172

82-
// Prior to CSI 1.0 - CSI plugins MUST implement both NodeGetId and
83-
// NodeGetInfo RPC calls.
8473
rpc NodeGetInfo (NodeGetInfoRequest)
8574
returns (NodeGetInfoResponse) {}
8675
}
@@ -1093,16 +1082,6 @@ message VolumeUsage {
10931082
// Units by which values are measured. This field is REQUIRED.
10941083
Unit unit = 4;
10951084
}
1096-
message NodeGetIdRequest {
1097-
// Intentionally empty.
1098-
}
1099-
1100-
message NodeGetIdResponse {
1101-
// The ID of the node as understood by the SP which SHALL be used by
1102-
// CO in subsequent `ControllerPublishVolume`.
1103-
// This is a REQUIRED field.
1104-
string node_id = 1;
1105-
}
11061085
message NodeGetCapabilitiesRequest {
11071086
// Intentionally empty.
11081087
}

0 commit comments

Comments
 (0)