Skip to content

Commit 7789780

Browse files
xing-yangjdef
authored andcommitted
Revert "Promote GetVolume and VolumeCondition to GA"
1 parent 9358408 commit 7789780

File tree

3 files changed

+278
-249
lines changed

3 files changed

+278
-249
lines changed

csi.proto

Lines changed: 18 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,9 @@ service Controller {
9797
returns (ControllerExpandVolumeResponse) {}
9898

9999
rpc ControllerGetVolume (ControllerGetVolumeRequest)
100-
returns (ControllerGetVolumeResponse) {}
100+
returns (ControllerGetVolumeResponse) {
101+
option (alpha_method) = true;
102+
}
101103
}
102104

103105
service Node {
@@ -882,7 +884,7 @@ message ListVolumesResponse {
882884
// This field is OPTIONAL.
883885
// This field MUST be specified if the
884886
// VOLUME_CONDITION controller capability is supported.
885-
VolumeCondition volume_condition = 2;
887+
VolumeCondition volume_condition = 2 [(alpha_field) = true];
886888
}
887889

888890
message Entry {
@@ -906,12 +908,16 @@ message ListVolumesResponse {
906908
string next_token = 2;
907909
}
908910
message ControllerGetVolumeRequest {
911+
option (alpha_message) = true;
912+
909913
// The ID of the volume to fetch current volume information for.
910914
// This field is REQUIRED.
911915
string volume_id = 1;
912916
}
913917

914918
message ControllerGetVolumeResponse {
919+
option (alpha_message) = true;
920+
915921
message VolumeStatus{
916922
// A list of all the `node_id` of nodes that this volume is
917923
// controller published on.
@@ -1056,12 +1062,14 @@ message ControllerServiceCapability {
10561062
// If for some reason Controller and Node Plugins report
10571063
// misaligned volume conditions, CO SHALL assume the worst case
10581064
// is the truth.
1059-
VOLUME_CONDITION = 11;
1065+
// Note that, for alpha, `VolumeCondition` is intended be
1066+
// informative for humans only, not for automation.
1067+
VOLUME_CONDITION = 11 [(alpha_enum_value) = true];
10601068

10611069
// Indicates the SP supports the ControllerGetVolume RPC.
10621070
// This enables COs to, for example, fetch per volume
10631071
// condition after a volume is provisioned.
1064-
GET_VOLUME = 12;
1072+
GET_VOLUME = 12 [(alpha_enum_value) = true];
10651073

10661074
// Indicates the SP supports the SINGLE_NODE_SINGLE_WRITER and/or
10671075
// SINGLE_NODE_MULTI_WRITER access modes.
@@ -1432,7 +1440,7 @@ message NodeGetVolumeStatsResponse {
14321440
// This field is OPTIONAL.
14331441
// This field MUST be specified if the VOLUME_CONDITION node
14341442
// capability is supported.
1435-
VolumeCondition volume_condition = 2;
1443+
VolumeCondition volume_condition = 2 [(alpha_field) = true];
14361444
}
14371445

14381446
message VolumeUsage {
@@ -1459,6 +1467,8 @@ message VolumeUsage {
14591467

14601468
// VolumeCondition represents the current condition of a volume.
14611469
message VolumeCondition {
1470+
option (alpha_message) = true;
1471+
14621472
// Normal volumes are available for use and operating optimally.
14631473
// An abnormal volume does not meet these criteria.
14641474
// This field is REQUIRED.
@@ -1499,7 +1509,9 @@ message NodeServiceCapability {
14991509
// If for some reason Node and Controller Plugins report
15001510
// misaligned volume conditions, CO SHALL assume the worst case
15011511
// is the truth.
1502-
VOLUME_CONDITION = 4;
1512+
// Note that, for alpha, `VolumeCondition` is intended to be
1513+
// informative for humans only, not for automation.
1514+
VOLUME_CONDITION = 4 [(alpha_enum_value) = true];
15031515

15041516
// Indicates the SP supports the SINGLE_NODE_SINGLE_WRITER and/or
15051517
// SINGLE_NODE_MULTI_WRITER access modes.

0 commit comments

Comments
 (0)