Skip to content

Commit 8fd698e

Browse files
authored
Merge pull request #314 from saad-ali/clarifyVolumeCap
Clarify VolumeCapability in CreateVolumeRequest
2 parents b08a16d + 0780bbf commit 8fd698e

File tree

3 files changed

+120
-98
lines changed

3 files changed

+120
-98
lines changed

csi.proto

Lines changed: 14 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -197,17 +197,22 @@ message CreateVolumeRequest {
197197
// specified it MUST always be honored, even when creating volumes
198198
// from a source; which may force some backends to internally extend
199199
// the volume after creating it.
200-
201200
CapacityRange capacity_range = 2;
202201

203-
// The capabilities that the provisioned volume MUST have: the Plugin
204-
// MUST provision a volume that could satisfy ALL of the
205-
// capabilities specified in this list. The Plugin MUST assume that
206-
// the CO MAY use the provisioned volume later with ANY of the
207-
// capabilities specified in this list. This also enables the CO to do
208-
// early validation: if ANY of the specified volume capabilities are
209-
// not supported by the Plugin, the call SHALL fail. This field is
210-
// REQUIRED.
202+
// The capabilities that the provisioned volume MUST have. SP MUST
203+
// provision a volume that will satisfy ALL of the capabilities
204+
// specified in this list. Otherwise SP MUST return the appropriate
205+
// gRPC error code.
206+
// The Plugin MUST assume that the CO MAY use the provisioned volume
207+
// with ANY of the capabilities specified in this list.
208+
// For example, a CO MAY specify two volume capabilities: one with
209+
// access mode SINGLE_NODE_WRITER and another with access mode
210+
// MULTI_NODE_READER_ONLY. In this case, the SP MUST verify that the
211+
// provisioned volume can be used in either mode.
212+
// This also enables the CO to do early validation: If ANY of the
213+
// specified volume capabilities are not supported by the SP, the call
214+
// MUST return the appropriate gRPC error code.
215+
// This field is REQUIRED.
211216
repeated VolumeCapability volume_capabilities = 3;
212217

213218
// Plugin specific parameters passed in as opaque key-value pairs.

0 commit comments

Comments
 (0)