Skip to content

Commit a033239

Browse files
James DeFelicejieyu
authored andcommitted
spec: simplify names of secrets fields
1 parent 177604d commit a033239

File tree

3 files changed

+333
-352
lines changed

3 files changed

+333
-352
lines changed

csi.proto

Lines changed: 9 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -218,8 +218,7 @@ message CreateVolumeRequest {
218218
// Secrets required by plugin to complete volume creation request.
219219
// This field is OPTIONAL. Refer to the `Secrets Requirements`
220220
// section on how to use this field.
221-
map<string, string> controller_create_secrets = 5
222-
[(csi_secret) = true];
221+
map<string, string> secrets = 5 [(csi_secret) = true];
223222

224223
// If specified, the new volume will be pre-populated with data from
225224
// this source. This field is OPTIONAL.
@@ -573,8 +572,7 @@ message DeleteVolumeRequest {
573572
// Secrets required by plugin to complete volume deletion request.
574573
// This field is OPTIONAL. Refer to the `Secrets Requirements`
575574
// section on how to use this field.
576-
map<string, string> controller_delete_secrets = 2
577-
[(csi_secret) = true];
575+
map<string, string> secrets = 2 [(csi_secret) = true];
578576
}
579577

580578
message DeleteVolumeResponse {
@@ -602,8 +600,7 @@ message ControllerPublishVolumeRequest {
602600
// Secrets required by plugin to complete controller publish volume
603601
// request. This field is OPTIONAL. Refer to the
604602
// `Secrets Requirements` section on how to use this field.
605-
map<string, string> controller_publish_secrets = 5
606-
[(csi_secret) = true];
603+
map<string, string> secrets = 5 [(csi_secret) = true];
607604

608605
// Attributes of the volume to be used on a node. This field is
609606
// OPTIONAL and MUST match the attributes of the Volume identified
@@ -634,8 +631,7 @@ message ControllerUnpublishVolumeRequest {
634631
// ControllerPublishVolume call for the specified volume.
635632
// This field is OPTIONAL. Refer to the `Secrets Requirements`
636633
// section on how to use this field.
637-
map<string, string> controller_unpublish_secrets = 3
638-
[(csi_secret) = true];
634+
map<string, string> secrets = 3 [(csi_secret) = true];
639635
}
640636

641637
message ControllerUnpublishVolumeResponse {
@@ -661,8 +657,7 @@ message ValidateVolumeCapabilitiesRequest {
661657
// Secrets required by plugin to complete volume validation request.
662658
// This field is OPTIONAL. Refer to the `Secrets Requirements`
663659
// section on how to use this field.
664-
map<string, string> controller_validate_secrets = 5
665-
[(csi_secret) = true];
660+
map<string, string> secrets = 5 [(csi_secret) = true];
666661
}
667662

668663
message ValidateVolumeCapabilitiesResponse {
@@ -819,7 +814,7 @@ message CreateSnapshotRequest {
819814
// Secrets required by plugin to complete snapshot creation request.
820815
// This field is OPTIONAL. Refer to the `Secrets Requirements`
821816
// section on how to use this field.
822-
map<string, string> create_snapshot_secrets = 3 [(csi_secret) = true];
817+
map<string, string> secrets = 3 [(csi_secret) = true];
823818

824819
// Plugin specific parameters passed in as opaque key-value pairs.
825820
// This field is OPTIONAL. The Plugin is responsible for parsing and
@@ -883,7 +878,7 @@ message DeleteSnapshotRequest {
883878
// Secrets required by plugin to complete snapshot deletion request.
884879
// This field is OPTIONAL. Refer to the `Secrets Requirements`
885880
// section on how to use this field.
886-
map<string, string> delete_snapshot_secrets = 2 [(csi_secret) = true];
881+
map<string, string> secrets = 2 [(csi_secret) = true];
887882
}
888883

889884
message DeleteSnapshotResponse {}
@@ -958,7 +953,7 @@ message NodeStageVolumeRequest {
958953
// Secrets required by plugin to complete node stage volume request.
959954
// This field is OPTIONAL. Refer to the `Secrets Requirements`
960955
// section on how to use this field.
961-
map<string, string> node_stage_secrets = 5 [(csi_secret) = true];
956+
map<string, string> secrets = 5 [(csi_secret) = true];
962957

963958
// Attributes of the volume to publish. This field is OPTIONAL and
964959
// MUST match the attributes of the `Volume` identified by
@@ -1020,7 +1015,7 @@ message NodePublishVolumeRequest {
10201015
// Secrets required by plugin to complete node publish volume request.
10211016
// This field is OPTIONAL. Refer to the `Secrets Requirements`
10221017
// section on how to use this field.
1023-
map<string, string> node_publish_secrets = 7 [(csi_secret) = true];
1018+
map<string, string> secrets = 7 [(csi_secret) = true];
10241019

10251020
// Attributes of the volume to publish. This field is OPTIONAL and
10261021
// MUST match the attributes of the Volume identified by

0 commit comments

Comments
 (0)