Skip to content

Commit f624381

Browse files
authored
Merge pull request #260 from verult/top-prefix
Updating prefix formats
2 parents 0361f62 + afe33d9 commit f624381

File tree

3 files changed

+118
-109
lines changed

3 files changed

+118
-109
lines changed

csi.proto

Lines changed: 15 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -89,13 +89,13 @@ message GetPluginInfoRequest {
8989
}
9090

9191
message GetPluginInfoResponse {
92-
// The name MUST follow reverse domain name notation format
93-
// (https://en.wikipedia.org/wiki/Reverse_domain_name_notation).
94-
// It SHOULD include the plugin's host company name and the plugin
95-
// name, to minimize the possibility of collisions. It MUST be 63
92+
// The name MUST follow domain name notation format
93+
// (https://tools.ietf.org/html/rfc1035#section-2.3.1). It SHOULD
94+
// include the plugin's host company name and the plugin name,
95+
// to minimize the possibility of collisions. It MUST be 63
9696
// characters or less, beginning and ending with an alphanumeric
97-
// character ([a-z0-9A-Z]) with dashes (-), underscores (_),
98-
// dots (.), and alphanumerics between. This field is REQUIRED.
97+
// character ([a-z0-9A-Z]) with dashes (-), dots (.), and
98+
// alphanumerics between. This field is REQUIRED.
9999
string name = 1;
100100

101101
// This field is REQUIRED. Value of this field is opaque to the CO.
@@ -533,12 +533,15 @@ message TopologyRequirement {
533533
// Valid keys have two segments: an optional prefix and name, separated
534534
// by a slash (/), for example: "com.company.example/zone".
535535
// The key name segment is required. The prefix is optional.
536-
// Both the key name and the prefix MUST each be 63 characters or less,
537-
// begin and end with an alphanumeric character ([a-z0-9A-Z]) and
538-
// contain only dashes (-), underscores (_), dots (.), or alphanumerics
539-
// in between, for example "zone".
540-
// The key prefix MUST follow reverse domain name notation format
541-
// (https://en.wikipedia.org/wiki/Reverse_domain_name_notation).
536+
// The key name MUST be 63 characters or less, begin and end with an
537+
// alphanumeric character ([a-z0-9A-Z]), and contain only dashes (-),
538+
// underscores (_), dots (.), or alphanumerics in between, for example
539+
// "zone".
540+
// The key prefix MUST be 63 characters or less, begin and end with a
541+
// lower-case alphanumeric character ([a-z0-9]), contain only
542+
// dashes (-), dots (.), or lower-case alphanumerics in between, and
543+
// follow domain name notation format
544+
// (https://tools.ietf.org/html/rfc1035#section-2.3.1).
542545
// The key prefix SHOULD include the plugin's host company name and/or
543546
// the plugin name, to minimize the possibility of collisions with keys
544547
// from other plugins.

0 commit comments

Comments
 (0)