Skip to content

Commit f946367

Browse files
authored
Merge pull request #325 from saad-ali/fixMayMust
Scrub spec for "should", "must", etc. and capitalize
2 parents 6e0f93b + 910c463 commit f946367

File tree

3 files changed

+138
-138
lines changed

3 files changed

+138
-138
lines changed

csi.proto

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ message PluginCapability {
118118

119119
// CONTROLLER_SERVICE indicates that the Plugin provides RPCs for
120120
// the ControllerService. Plugins SHOULD provide this capability.
121-
// In rare cases certain plugins may wish to omit the
121+
// In rare cases certain plugins MAY wish to omit the
122122
// ControllerService entirely from their implementation, but such
123123
// SHOULD NOT be the common case.
124124
// The presence of this capability determines whether the CO will
@@ -127,7 +127,7 @@ message PluginCapability {
127127
CONTROLLER_SERVICE = 1;
128128

129129
// VOLUME_ACCESSIBILITY_CONSTRAINTS indicates that the volumes for
130-
// this plugin may not be equally accessible by all nodes in the
130+
// this plugin MAY NOT be equally accessible by all nodes in the
131131
// cluster. The CO MUST use the topology information returned by
132132
// CreateVolumeRequest along with the topology information
133133
// returned by NodeGetInfo to ensure that a given volume is
@@ -173,7 +173,7 @@ message CreateVolumeRequest {
173173
// The suggested name for the storage space. This field is REQUIRED.
174174
// It serves two purposes:
175175
// 1) Idempotency - This name is generated by the CO to achieve
176-
// idempotency. The Plugin should ensure that multiple
176+
// idempotency. The Plugin SHOULD ensure that multiple
177177
// `CreateVolume` calls for the same name do not result in more
178178
// than one piece of storage provisioned corresponding to that
179179
// name. If a Plugin is unable to enforce idempotency, the CO's
@@ -202,7 +202,7 @@ message CreateVolumeRequest {
202202
// requirement of the volume to be provisioned. If not specified, the
203203
// Plugin MAY choose an implementation-defined capacity range. If
204204
// specified it MUST always be honored, even when creating volumes
205-
// from a source; which may force some backends to internally extend
205+
// from a source; which MAY force some backends to internally extend
206206
// the volume after creating it.
207207
CapacityRange capacity_range = 2;
208208

@@ -384,7 +384,7 @@ message Volume {
384384
// The contents of this field SHOULD NOT contain sensitive
385385
// information.
386386
// The contents of this field SHOULD NOT be used for uniquely
387-
// identifying a volume. The `volume_id` alone should be sufficient to
387+
// identifying a volume. The `volume_id` alone SHOULD be sufficient to
388388
// identify the volume.
389389
// A volume uniquely identified by `volume_id` SHALL always report the
390390
// same volume_context.
@@ -408,7 +408,7 @@ message Volume {
408408
// from a given node when scheduling workloads.
409409
// This field is OPTIONAL. If it is not specified, the CO MAY assume
410410
// the volume is equally accessible from all nodes in the cluster and
411-
// may schedule workloads referencing the volume on any available
411+
// MAY schedule workloads referencing the volume on any available
412412
// node.
413413
//
414414
// Example 1:
@@ -562,9 +562,9 @@ message TopologyRequirement {
562562
// A topological segment is a specific instance of a topological domain,
563563
// like "zone3", "rack3", etc.
564564
// For example {"com.company/zone": "Z1", "com.company/rack": "R3"}
565-
// Valid keys have two segments: an optional prefix and name, separated
565+
// Valid keys have two segments: an OPTIONAL prefix and name, separated
566566
// by a slash (/), for example: "com.company.example/zone".
567-
// The key name segment is required. The prefix is optional.
567+
// The key name segment is REQUIRED. The prefix is OPTIONAL.
568568
// The key name MUST be 63 characters or less, begin and end with an
569569
// alphanumeric character ([a-z0-9A-Z]), and contain only dashes (-),
570570
// underscores (_), dots (.), or alphanumerics in between, for example
@@ -644,7 +644,7 @@ message ControllerPublishVolumeResponse {
644644
// The contents of this field SHOULD NOT contain sensitive
645645
// information.
646646
// The contents of this field SHOULD NOT be used for uniquely
647-
// identifying a volume. The `id` alone should be sufficient to
647+
// identifying a volume. The `volume_id` alone SHOULD be sufficient to
648648
// identify the volume.
649649
// This field is OPTIONAL and when present MUST be passed to
650650
// subsequent `NodeStageVolume` or `NodePublishVolume` calls
@@ -817,9 +817,9 @@ message ControllerServiceCapability {
817817
CREATE_DELETE_SNAPSHOT = 5;
818818
LIST_SNAPSHOTS = 6;
819819
// Plugins supporting volume cloning at the storage level MAY
820-
// report this capability. The source volume must be managed by
820+
// report this capability. The source volume MUST be managed by
821821
// the same plugin. Not all volume sources and parameters
822-
// combinations may work.
822+
// combinations MAY work.
823823
CLONE_VOLUME = 7;
824824
// Indicates the SP supports ControllerPublishVolume.readonly
825825
// field.
@@ -900,7 +900,7 @@ message Snapshot {
900900
string source_volume_id = 3;
901901

902902
// Timestamp when the point-in-time snapshot is taken on the storage
903-
// system. The format of this field should be a Unix nanoseconds time
903+
// system. The format of this field SHOULD be a Unix nanoseconds time
904904
// encoded as an int64. On Unix, the command `date +%s%N` returns the
905905
// current time in nanoseconds since 1970-01-01 00:00:00 UTC. This
906906
// field is REQUIRED.

0 commit comments

Comments
 (0)