cgroup2: should add IN_CLOEXEC for inotify fd

fuweid · fuweid · commit 31280a15316b · 2025-10-24T21:58:59.000-04:00
REF: https://man7.org/linux/man-pages/man2/inotify_init.2.html Signed-off-by: Wei Fu <fuweid89@gmail.com>
diff --git a/cgroup2/manager.go b/cgroup2/manager.go
@@ -745,7 +745,7 @@ func (c *Manager) isCgroupEmpty() bool {
 // MemoryEventFD returns inotify file descriptor and 'memory.events' inotify watch descriptor
 func (c *Manager) MemoryEventFD() (int, uint32, error) {
 	fpath := filepath.Join(c.path, "memory.events")
-	fd, err := unix.InotifyInit()
+	fd, err := unix.InotifyInit1(unix.IN_CLOEXEC)
 	if err != nil {
 		return 0, 0, fmt.Errorf("failed to create inotify fd: %w", err)
 	}

Original file line number	Diff line number	Diff line change
`@@ -745,7 +745,7 @@ func (c *Manager) isCgroupEmpty() bool {`
`745`	`745`	`// MemoryEventFD returns inotify file descriptor and 'memory.events' inotify watch descriptor`
`746`	`746`	`func (c *Manager) MemoryEventFD() (int, uint32, error) {`
`747`	`747`	`fpath := filepath.Join(c.path, "memory.events")`
`748`		`- fd, err := unix.InotifyInit()`
	`748`	`+ fd, err := unix.InotifyInit1(unix.IN_CLOEXEC)`
`749`	`749`	`if err != nil {`
`750`	`750`	`return 0, 0, fmt.Errorf("failed to create inotify fd: %w", err)`
`751`	`751`	`}`