fix: don't abort on first encountered error when resetting Windows console

When resetting the Windows console modes, we must not abort on the
first encountered error, otherwise we might leave the console in an
unexpected state.

This is easily reproducible by calling SetRaw while stdout is
redirected: Reset will abort restoring console modes after failing
to reset stdout, which leaves stderr in its raw state.

Signed-off-by: Christian Muehlhaeuser <[email protected]>

Author: muesli

console_windows.go

@@ -94,6 +94,8 @@ func (m *master) SetRaw() error {
 }
 
 func (m *master) Reset() error {
+	var errs []error
+
 	for _, s := range []struct {
 		fd   windows.Handle
 		mode uint32
@@ -103,10 +105,16 @@ func (m *master) Reset() error {
 		{m.err, m.errMode},
 	} {
 		if err := windows.SetConsoleMode(s.fd, s.mode); err != nil {
-			return fmt.Errorf("unable to restore console mode: %w", err)
+			// we can't just abort on the first error, otherwise we might leave
+			// the console in an unexpected state.
+			errs = append(errs, fmt.Errorf("unable to restore console mode: %w", err))
 		}
 	}
 
+	if len(errs) > 0 {
+		return errs[0]
+	}
+
 	return nil
 }