update golangci-lint (2.4.0); silence new errors

Some rules are disabled to silence the errors introduced in
this release of golangci-lint.

See PR 4490

Signed-off-by: Akihiro Suda <[email protected]>

Author: AkihiroSuda

.golangci.yml

@@ -99,6 +99,9 @@ linters:
         - name: use-errors-new
           # 84 occurrences. Improves error testing.
           disabled: true
+        - name: struct-tag
+          # 2 occurrences.
+          disabled: true
 
         ##### P1: consider making a dent on these, but not critical.
         - name: argument-limit
@@ -131,6 +134,9 @@ linters:
         - name: cognitive-complexity
           arguments: [205]
           # 441 occurrences (at default 7). We should try to lower it (involves significant refactoring).
+        - name: var-naming
+          # 1 occurrence.
+          disabled: true
 
         ##### P2: nice to have.
         - name: max-public-structs
@@ -155,6 +161,9 @@ linters:
         - name: exported
           # 577 occurrences. Forces documentation of any exported symbol.
           disabled: true
+        - name: unnecessary-format
+          # Many occurrences.
+          disabled: true
 
         ###### Permanently disabled. Below have been reviewed and vetted to be unnecessary.
         - name: line-length-limit
@@ -175,6 +184,9 @@ linters:
         - name: add-constant
           # 2605 occurrences. Kind of useful in itself, but unacceptable amount of effort to fix
           disabled: true
+        - name: enforce-switch-style
+          # Many occurrences.
+          disabled: true
 
     depguard:
       rules:
@@ -241,7 +253,6 @@ linters:
         - typeAssertChain
         - unlabelStmt
         - builtinShadow
-        - importShadow
         - initClause
         - nestingReduce
         - unnecessaryBlock

Makefile

@@ -217,15 +217,15 @@ fix-mod:
 ##########################
 install-dev-tools:
 	$(call title, $@)
-	# golangci: v2.0.2 (2024-03-26)
+	# golangci: v2.4.0 (2025-08-14)
 	# git-validation: main (2025-02-25)
 	# ltag: main (2025-03-04)
 	# go-licenses: v2.0.0-alpha.1 (2024-06-27)
 	# stubbing go-licenses with dependency upgrade due to non-compatibility with golang 1.25rc1
 	# Issue: https://github.com/google/go-licenses/issues/312
 	@cd $(MAKEFILE_DIR) \
 	        && go install github.com/Shubhranshu153/go-licenses/v2@f8c503d1357dffb6c97ed3b94e912ab294dde24a \
-		&& go install github.com/golangci/golangci-lint/v2/cmd/golangci-lint@2b224c2cf4c9f261c22a16af7f8ca6408467f338 \
+		&& go install github.com/golangci/golangci-lint/v2/cmd/golangci-lint@43d03392d7dc3746fa776dbddd66dfcccff70651 \
 		&& go install github.com/vbatts/git-validation@7b60e35b055dd2eab5844202ffffad51d9c93922 \
 		&& go install github.com/containerd/ltag@66e6a514664ee2d11a470735519fa22b1a9eaabd \
 		&& go install gotest.tools/gotestsum@0d9599e513d70e5792bb9334869f82f6e8b53d4d

mod/tigron/.golangci.yml

@@ -54,6 +54,10 @@ linters:
     - sloglint          # no slog
     - testifylint       # no testify
     - zerologlint       # no zerolog
+    - funcorder
+    - noctx
+    - noinlineerr
+    - wsl_v5
   settings:
     interfacebloat:
       # Default is 10
@@ -91,6 +95,12 @@ linters:
             - "fmt.Fprint"
             - "fmt.Fprintln"
             - "fmt.Fprintf"
+        - name: redundant-test-main-exit
+          disabled: true
+        - name: enforce-switch-style
+          disabled: true
+        - name: var-naming
+          disabled: true
     depguard:
       rules:
         main:

mod/tigron/Makefile

@@ -164,14 +164,14 @@ up:
 ##########################
 install-dev-tools:
 	$(call title, $@)
-	# golangci: v2.0.2 (2024-03-26)
+	# golangci: v2.4.0 (2025-08-14)
 	# git-validation: main (2025-02-25)
 	# ltag: main (2025-03-04)
 	# go-licenses: v2.0.0-alpha.1 (2024-06-27)
 	# stubbing go-licenses with dependency upgrade due to non-compatibility with golang 1.25rc1
 	# Issue: https://github.com/google/go-licenses/issues/312
 	@cd $(MAKEFILE_DIR) \
-		&& go install github.com/golangci/golangci-lint/v2/cmd/golangci-lint@2b224c2cf4c9f261c22a16af7f8ca6408467f338 \
+		&& go install github.com/golangci/golangci-lint/v2/cmd/golangci-lint@43d03392d7dc3746fa776dbddd66dfcccff70651 \
 		&& go install github.com/vbatts/git-validation@7b60e35b055dd2eab5844202ffffad51d9c93922 \
 		&& go install github.com/containerd/ltag@66e6a514664ee2d11a470735519fa22b1a9eaabd \
 		&& go install github.com/Shubhranshu153/go-licenses/v2@f8c503d1357dffb6c97ed3b94e912ab294dde24a