Skip to content

Commit 2aad180

Browse files
authored
Merge pull request #4128 from apostasie/fix-main-bustage
[URGENT] Fixing main cross-merge bustage
2 parents dce438f + 24c8654 commit 2aad180

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

.golangci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ linters:
128128
##### P2: nice to have.
129129
- name: max-public-structs
130130
# 7 occurrences (at default 5). Might indicate overcrowding of public API.
131-
arguments: [21]
131+
arguments: [25]
132132
- name: confusing-results
133133
# 13 occurrences. Have named returns when the type stutters.
134134
# Makes it a bit easier to figure out function behavior just looking at signature.

cmd/nerdctl/network/network_inspect_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -288,7 +288,7 @@ func TestNetworkInspect(t *testing.T) {
288288
helpers.Ensure("create", "--name", data.Identifier("nginx-container-2"), "--network", data.Identifier("nginx-network-1"), testutil.NginxAlpineImage)
289289
helpers.Ensure("create", "--name", data.Identifier("nginx-container-on-diff-network"), "--network", data.Identifier("nginx-network-2"), testutil.NginxAlpineImage)
290290
helpers.Ensure("start", data.Identifier("nginx-container-1"), data.Identifier("nginx-container-on-diff-network"))
291-
data.Set("nginx-container-1-id", strings.Trim(helpers.Capture("inspect", data.Identifier("nginx-container-1"), "--format", "{{.Id}}"), "\n"))
291+
data.Labels().Set("nginx-container-1-id", strings.Trim(helpers.Capture("inspect", data.Identifier("nginx-container-1"), "--format", "{{.Id}}"), "\n"))
292292
},
293293
Cleanup: func(data test.Data, helpers test.Helpers) {
294294
helpers.Anyhow("rm", "-f", data.Identifier("nginx-container-1"))
@@ -310,7 +310,7 @@ func TestNetworkInspect(t *testing.T) {
310310
assert.Equal(t, dc[0].Name, data.Identifier("nginx-network-1"))
311311
// Assert only the "running" containers on the same network are returned.
312312
assert.Equal(t, 1, len(dc[0].Containers), "Expected a single container as per configuration, but got multiple.")
313-
assert.Equal(t, data.Identifier("nginx-container-1"), dc[0].Containers[data.Get("nginx-container-1-id")].Name)
313+
assert.Equal(t, data.Identifier("nginx-container-1"), dc[0].Containers[data.Labels().Get("nginx-container-1-id")].Name)
314314
},
315315
}
316316
},

0 commit comments

Comments
 (0)