Move to creack pty

Signed-off-by: apostasie <[email protected]>

Author: apostasie

go.mod

@@ -81,6 +81,7 @@ require (
 	github.com/containerd/plugin v1.0.0 // indirect
 	github.com/containerd/ttrpc v1.2.7 // indirect
 	github.com/containers/ocicrypt v1.2.1 // indirect
+	github.com/creack/pty v1.1.24 // indirect
 	github.com/djherbis/times v1.6.0 // indirect
 	github.com/docker/docker-credential-helpers v0.8.2 // indirect
 	github.com/felixge/httpsnoop v1.0.4 // indirect

go.sum

@@ -76,8 +76,8 @@ github.com/coreos/go-iptables v0.8.0/go.mod h1:Qe8Bv2Xik5FyTXwgIbLAnv2sWSBmvWdFE
 github.com/coreos/go-systemd/v22 v22.5.0 h1:RrqgGjYQKalulkV8NGVIfkXQf6YYmOyiJKk8iXXhfZs=
 github.com/coreos/go-systemd/v22 v22.5.0/go.mod h1:Y58oyj3AT4RCenI/lSvhwexgC+NSVTIJ3seZv2GcEnc=
 github.com/cpuguy83/go-md2man/v2 v2.0.6/go.mod h1:oOW0eioCTA6cOiMLiUPZOpcVxMig6NIQQ7OS05n1F4g=
-github.com/creack/pty v1.1.18 h1:n56/Zwd5o6whRC5PMGretI4IdRLlmBXYNjScPaBgsbY=
-github.com/creack/pty v1.1.18/go.mod h1:MOBLtS5ELjhRRrroQr9kyvTxUAFNvYEK993ew/Vr4O4=
+github.com/creack/pty v1.1.24 h1:bJrF4RRfyJnbTJqzRLHzcGaZK1NeM5kTC9jGgovnR1s=
+github.com/creack/pty v1.1.24/go.mod h1:08sCNb52WyoAwi2QDyzUCTgcvVFhUzewun7wtTfvcwE=
 github.com/cyphar/filepath-securejoin v0.4.1 h1:JyxxyPEaktOD+GAnqIqTf9A8tHyAG22rowi7HkoSU1s=
 github.com/cyphar/filepath-securejoin v0.4.1/go.mod h1:Sdj7gXlvMcPZsbhwhQ33GguGLDGQL7h7bg04C/+u9jI=
 github.com/davecgh/go-spew v1.1.0/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=

mod/tigron/go.mod

@@ -3,6 +3,7 @@ module github.com/containerd/nerdctl/mod/tigron
 go 1.23
 
 require (
+	github.com/creack/pty v1.1.24
 	golang.org/x/sync v0.11.0
 	golang.org/x/term v0.29.0
 	gotest.tools/v3 v3.5.2

mod/tigron/go.sum

@@ -1,3 +1,5 @@
+github.com/creack/pty v1.1.24 h1:bJrF4RRfyJnbTJqzRLHzcGaZK1NeM5kTC9jGgovnR1s=
+github.com/creack/pty v1.1.24/go.mod h1:08sCNb52WyoAwi2QDyzUCTgcvVFhUzewun7wtTfvcwE=
 github.com/google/go-cmp v0.6.0 h1:ofyhxvXcZhMsU5ulbFiLKl/XBFqE1GSq7atu8tAmTRI=
 github.com/google/go-cmp v0.6.0/go.mod h1:17dUlkBOakJ0+DkrSSNjCkIjxS6bF9zb3elmeNGIjoY=
 golang.org/x/sync v0.11.0 h1:GGz8+XQP4FvTTrjZPzNKTMFtSXH80RAzG+5ghFPgK9w=

mod/tigron/test/internal/pty/pty.go

@@ -14,11 +14,33 @@
    limitations under the License.
 */
 
+// Package pty.
+// Note that creack is MIT licensed, making it better to depend on it rather than using derived code here.
+// Underlying creack implementation is OK though they have more (unnecessary to us) features and do not follow the
+// same coding standards.
 package pty
 
-import "errors"
+import (
+	"errors"
+	"os"
+
+	creack "github.com/creack/pty"
+)
 
 var (
-	ErrPTYFailure             = errors.New("pty failure")
-	ErrPTYUnsupportedPlatform = errors.New("pty not supported on this platform")
+	ErrFailure             = errors.New("pty failure")
+	ErrUnsupportedPlatform = errors.New("pty not supported on this platform")
 )
+
+func Open() (*os.File, *os.File, error) {
+	pty, tty, err := creack.Open()
+	if err != nil {
+		if errors.Is(err, creack.ErrUnsupported) {
+			err = errors.Join(ErrUnsupportedPlatform, err)
+		} else {
+			err = errors.Join(ErrFailure, err)
+		}
+	}
+
+	return pty, tty, err
+}