Skip to content

Commit cc81c72

Browse files
committed
Remove golanci-lint action
Depending on the action means depending on a precompiled version of it that is incompatible with updated golang versions. Alternatively, the action offers to build it from source, but unfortunately, the specific GOOS has to apply for both the compilation and verification stages. The action also performs additional steps (--verify) that are unnecessary and have been a source of issues. Finally, golangci-lint version has to be maintained in two distinct places: - local developer environment - github CI side Removing the action in favor of calling `make install-dev-tools` will fix these issues. Signed-off-by: apostasie <[email protected]>
1 parent 1838cd8 commit cc81c72

File tree

1 file changed

+5
-7
lines changed

1 file changed

+5
-7
lines changed

.github/workflows/lint.yml

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,6 @@ jobs:
3535
goos: linux
3636
# This allows the canary script to select any upcoming golang alpha/beta/RC
3737
canary: go-canary
38-
env:
39-
GOOS: "${{ matrix.goos }}"
4038
steps:
4139
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
4240
with:
@@ -52,12 +50,12 @@ jobs:
5250
with:
5351
go-version: ${{ env.GO_VERSION }}
5452
check-latest: true
53+
- name: install required linters and dev-tools
54+
run: |
55+
make install-dev-tools
5556
- name: golangci-lint
56-
uses: golangci/golangci-lint-action@2226d7cb06a077cd73e56eedd38eecad18e5d837 # v6.5.0
57-
with:
58-
args: --verbose
59-
# See https://github.com/containerd/nerdctl/issues/3914
60-
verify: false
57+
run: |
58+
NO_COLOR=true GOOS="${{ matrix.goos }}" make lint-go
6159
other:
6260
timeout-minutes: 5
6361
name: yaml | shell | imports order

0 commit comments

Comments
 (0)