While start the shim fail, ensure the socket file has been remove

Discovered socket file leak when set_cgroup_ond_oom_store execution failed

Signed-off-by: jokemanfire <[email protected]>

Author: jokemanfire

crates/shim/src/asynchronous/mod.rs

@@ -344,11 +344,21 @@ pub async fn spawn(opts: StartOpts, grouping: &str, vars: Vec<(&str, &str)>) ->
         command.arg("-debug");
     }
     command.envs(vars);
-
-    let _child = command.spawn().map_err(io_error!(e, "spawn shim"))?;
+    // if fail we should remove socket
+    let result = command.spawn().map_err(io_error!(e, "spawn shim"));
+    if result.is_err() {
+        remove_socket(&address).await?;
+    }
+    let _child = result?;
+    // if fail we should remove socket
     #[cfg(target_os = "linux")]
-    crate::cgroup::set_cgroup_and_oom_score(_child.id())?;
-    Ok(address)
+    match crate::cgroup::set_cgroup_and_oom_score(_child.id()) {
+        Ok(_) => Ok(address),
+        Err(error) => {
+            remove_socket(&address).await?;
+            Err(error)
+        }
+    }
 }
 
 #[cfg_attr(feature = "tracing", tracing::instrument(skip_all, level = "info"))]