Check for errors when connecting to client

The unwrap() causes a panic.  This can happen if the file doesn't exist or there is a small chance when mutliple clients connect quickly that the pipe returns 'All pipe instances are busy.' also causing a panic.  This allows the caller to handle these errors and retry if necessary (as is the case with the pipe instances being busy).

Signed-off-by: James Sturtevant <[email protected]>

Author: jsturtevant

src/error.rs

@@ -19,7 +19,7 @@ use std::result;
 use thiserror::Error;
 
 /// The error type for ttrpc.
-#[derive(Error, Debug, Clone)]
+#[derive(Error, Debug, Clone, PartialEq)]
 pub enum Error {
     #[error("socket err: {0}")]
     Socket(String),

src/sync/sys/windows/net.rs

@@ -321,9 +321,14 @@ impl ClientConnection {
         opts.read(true)
             .write(true)
             .custom_flags(FILE_FLAG_OVERLAPPED);
-        let file = opts.open(self.address.as_str());
-
-        return PipeConnection::new(file.unwrap().into_raw_handle() as isize)
+        match opts.open(self.address.as_str()) {
+            Ok(file) => {
+                return PipeConnection::new(file.into_raw_handle() as isize)
+            }
+            Err(e) => {
+                return Err(Error::Windows(e.raw_os_error().unwrap()))
+            }
+        }
     }
 
     pub fn close_receiver(&self) -> Result<()> {
@@ -336,3 +341,22 @@ impl ClientConnection {
         Ok(())
     }
 }
+
+#[cfg(test)]
+mod test {
+    use super::*;
+    use windows_sys::Win32::Foundation::ERROR_FILE_NOT_FOUND;
+
+    #[test]
+    fn test_pipe_connection() {
+        let client = ClientConnection::new("non_existent_pipe");
+        match client.get_pipe_connection() {
+            Ok(_) => {
+                assert!(false, "should not be able to get a connection to a non existent pipe");
+            }
+            Err(e) => {
+                assert_eq!(e, Error::Windows(ERROR_FILE_NOT_FOUND as i32));
+            }
+        }
+    }
+}