Add systeminfo module

Signed-off-by: Sagi Shnaidman <[email protected]>

Author: johnsonlien

plugins/modules/podman_system_info.py

@@ -3,9 +3,10 @@
 # GNU General Public License v3.0+ (see COPYING or https://www.gnu.org/licenses/gpl-3.0.txt)
 
 from __future__ import absolute_import, division, print_function
+
 __metaclass__ = type
 
-DOCUMENTATION = r'''
+DOCUMENTATION = r"""
 module: podman_system_info
 author:
   - Johnson Lien (@johnsonlien)
@@ -20,9 +21,9 @@
         machine running C(podman)
     default: 'podman'
     type: str
-'''
+"""
 
-EXAMPLES = r'''
+EXAMPLES = r"""
 - name: Get Podman system information
   containers.podman.podman_system_info:
 
@@ -32,9 +33,9 @@
 - name: Printing Podman System info
   debug:
     msg: "{{ podman_info['podman_system_info'] }}"
-'''
+"""
 
-RETURN = r'''
+RETURN = r"""
 host:
   arch: amd64
   buildahVersion: 1.23.0
@@ -44,11 +45,11 @@
   conmon:
     package: conmon-2.0.29-2.fc34.x86_64
     path: /usr/bin/conmon
-    version: 'conmon version 2.0.29, commit: '
- cpu_utilization:
-   idle_percent: 96.84
-   system_percent: 0.71
-   user_percent: 2.45
+    version: 'conmon version 2.0.29, commit:'
+  cpu_utilization:
+    idle_percent: 96.84
+    system_percent: 0.71
+    user_percent: 2.45
   cpus: 8
   distribution:
     distribution: fedora
@@ -178,31 +179,36 @@
   GoVersion: go1.16.6
   OsArch: linux/amd64
   Version: 4.0.0
-'''
+"""
 
 import json
 
 from ansible.module_utils.basic import AnsibleModule
 
+
 def get_podman_system_info(module, executable):
-    command = [executable, 'system', 'info']
-    rc, out, err = module.run_command(command)
+    command = [executable, "system", "info", "--format", "json"]
+    _, out, err = module.run_command(command)
     out = out.strip()
     if out:
-        return json.loads(out)
+        try:
+            return json.loads(out)
+        except Exception as e:
+            module.fail_json(
+                msg="Failed to parse podman system info output: error: %s, output: %s err: %s" % (e, out, err),
+                exception=str(e),
+            )
 
-    module.log(msg="Unable to get podman system info: %s" % err)
-    return json.dumps([])
 
 def main():
     module = AnsibleModule(
         argument_spec=dict(
-            executable=dict(type='str', default='podman'),
+            executable=dict(type="str", default="podman"),
         ),
         supports_check_mode=True,
     )
 
-    executable = module.get_bin_path(module.params['executable'], required=True)
+    executable = module.get_bin_path(module.params["executable"], required=True)
 
     results = get_podman_system_info(module, executable)
 
@@ -213,5 +219,6 @@ def main():
 
     module.exit_json(**results)
 
-if __name__ == '__main__':
+
+if __name__ == "__main__":
     main()

tests/integration/targets/podman_system_info/tasks/main.yml

@@ -1,8 +1,9 @@
 - name: Get Podman system info
   containers.podman.podman_system_info:
+  executable: "{{ test_executable | default('podman') }}"
   register: podman_info
 
 - name: Check results
-  assert: 
+  assert:
     that:
       - podman_info.podman_system_info | length > 0