podman_container_lib: Added checks for volume opts (#941)

* podman_container_lib: Added checks for volume opts

Changed the diffparam_volume function to include the volume mount opts.

Signed-off-by: Lucas Benedito <[email protected]>

* Add test for volume mount options

Signed-off-by: Lucas Benedito <[email protected]>

---------

Signed-off-by: Lucas Benedito <[email protected]>

Author: lucas-benedito

plugins/module_utils/podman/podman_container_lib.py

@@ -1560,12 +1560,12 @@ def clean_volume(x):
         after = self.params["volume"]
         if after is not None:
             after = [
-                ":".join([clean_volume(i) for i in v.split(":")[:2]])
+                ":".join([clean_volume(i) for i in v.split(":")[:3]])
                 for v in self.params["volume"]
             ]
         if before is not None:
             before = [
-                ":".join([clean_volume(i) for i in v.split(":")[:2]]) for v in before
+                ":".join([clean_volume(i) for i in v.split(":")[:3]]) for v in before
             ]
         if before is None and after is None:
             return self._diff_update_and_compare("volume", before, after)

tests/integration/targets/podman_container_idempotency/tasks/idem_volumes.yml

@@ -349,3 +349,36 @@
 - name: check test23
   assert:
     that: test23 is not changed
+
+- ansible.builtin.file:
+    path: /tmp/data
+    state: directory
+
+- containers.podman.podman_container:
+    executable: "{{ test_executable | default('podman') }}"
+    name: test24
+    image: alpine
+    state: present
+    volumes:
+      - /tmp/data:/data:z
+
+- containers.podman.podman_container:
+    executable: "{{ test_executable | default('podman') }}"
+    name: test24
+    image: alpine
+    state: present
+    volumes:
+      - /tmp/data:/data:U
+  register: test24
+
+- name: Check test24
+  assert:
+    that:
+      - test24 is changed
+      - >-
+        (test24.container['Config']['CreateCommand'] is defined and
+        '/tmp/data:/data:U' in test24.container['Config']['CreateCommand'] | list)
+
+- ansible.builtin.file:
+    path: /tmp/data
+    state: absent