Skip to content

Commit e394398

Browse files
authored
[FIX] Issue #529: become plugin podman_unshare become_user default (#530)
Signed-off-by: Janos Gerzson <[email protected]> Signed-off-by: Janos Gerzson <[email protected]>
1 parent 73af489 commit e394398

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

plugins/become/podman_unshare.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,7 @@
1717
version_added: 1.9.0
1818
options:
1919
become_user:
20-
description: User you 'become' to execute the task
21-
default: root
20+
description: User you 'become' to execute the task ('root' is not a valid value here).
2221
ini:
2322
- section: privilege_escalation
2423
key: become_user
@@ -130,8 +129,8 @@ def build_become_command(self, cmd, shell):
130129

131130
becomecmd = 'podman unshare'
132131

133-
user = self.get_option('become_user') or ''
134-
if user:
132+
user = self.get_option('become_user') or 'root'
133+
if user != 'root':
135134
cmdlist = [self.get_option('become_exe') or 'sudo']
136135
# -i is required, because
137136
# podman unshare should be executed in a login shell to avoid chdir permission errors

0 commit comments

Comments
 (0)