@@ -198,6 +198,7 @@ impl ZstdWriter {
198
198
Ok ( self . writer . write_all ( data) ?)
199
199
}
200
200
201
+ /// Writes all the data in `inline_content`, updating the internal SHA
201
202
pub ( crate ) fn flush_inline ( & mut self , inline_content : & Vec < u8 > ) -> Result < ( ) > {
202
203
if inline_content. is_empty ( ) {
203
204
return Ok ( ( ) ) ;
@@ -212,6 +213,8 @@ impl ZstdWriter {
212
213
Ok ( ( ) )
213
214
}
214
215
216
+ /// Keeps popping from the heap until it reaches the message with the largest seq_num, n,
217
+ /// given we have every message with seq_num < n
215
218
fn write_message ( & mut self ) -> Result < ( ) > {
216
219
loop {
217
220
// Gotta keep lifetime of the destructring inside the loop
@@ -234,9 +237,7 @@ impl ZstdWriter {
234
237
sha256. update ( data. 0 . object_data . external_data ) ;
235
238
}
236
239
237
- if let Err ( e) = self . write_fragment ( 0 , & data. 0 . digest ) {
238
- println ! ( "write_fragment err while writing external content: {e:?}" ) ;
239
- }
240
+ self . write_fragment ( 0 , & data. 0 . digest ) ?;
240
241
}
241
242
242
243
let final_msg = self . get_state_mut ( ) . final_message . take ( ) ;
@@ -281,6 +282,7 @@ impl ZstdWriter {
281
282
return Ok ( sha) ;
282
283
}
283
284
285
+ /// Calls `finish` on the internal writer
284
286
pub ( crate ) fn finish ( self ) -> io:: Result < Vec < u8 > > {
285
287
self . writer . finish ( )
286
288
}
@@ -310,7 +312,8 @@ impl ZstdWriter {
310
312
}
311
313
312
314
// Cannot `take` ownership of self, as we'll need it later
313
- // returns whether finished or not
315
+ //
316
+ /// Returns whether we have finished writing all the data or not
314
317
fn handle_received_data ( & mut self , data : WriterMessages ) -> Result < bool > {
315
318
match data {
316
319
WriterMessages :: WriteData ( recv_data) => {
@@ -321,11 +324,6 @@ impl ZstdWriter {
321
324
let object_path = Repository :: format_object_path ( & recv_data. digest ) ;
322
325
self . repository . ensure_symlink ( & stream_path, & object_path) ?;
323
326
324
- // if let Some(name) = reference {
325
- // let reference_path = format!("streams/refs/{name}");
326
- // self.symlink(&reference_path, &stream_path)?;
327
- // }
328
-
329
327
if let Err ( e) = self
330
328
. get_state ( )
331
329
. final_result_sender
0 commit comments