Skip to content

Commit e4e8c28

Browse files
oci: don't await the image-proxy GetBlob driver
This can cause the proxy's control channel to experience lockups in heavily-threaded situations and we don't gain any benefit from doing it. Just drop it. See bootc-dev/containers-image-proxy-rs#80 Signed-off-by: Allison Karlitskaya <[email protected]>
1 parent 06b5368 commit e4e8c28

File tree

1 file changed

+7
-1
lines changed

1 file changed

+7
-1
lines changed

src/oci/mod.rs

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -136,7 +136,13 @@ impl<ObjectID: FsVerityHashValue> ImageOp<ObjectID> {
136136
other => bail!("Unsupported layer media type {:?}", other),
137137
};
138138
let layer_id = self.repo.write_stream(splitstream, None)?;
139-
driver.await?;
139+
140+
// We intentionally explicitly ignore this, even though we're supposed to check it.
141+
// See https://github.com/containers/containers-image-proxy-rs/issues/80 for discussion
142+
// about why. Note: we only care about the uncompressed layer tar, and we checksum it
143+
// ourselves.
144+
drop(driver);
145+
140146
Ok(layer_id)
141147
}
142148
}

0 commit comments

Comments
 (0)