|
| 1 | +package store |
| 2 | + |
| 3 | +import ( |
| 4 | + "fmt" |
| 5 | + "os" |
| 6 | + "path/filepath" |
| 7 | + "testing" |
| 8 | + |
| 9 | + "github.com/stretchr/testify/assert" |
| 10 | + "github.com/stretchr/testify/require" |
| 11 | + "go.podman.io/image/v5/types" |
| 12 | +) |
| 13 | + |
| 14 | +func TestNewArtifactReference(t *testing.T) { |
| 15 | + // Test valid reference |
| 16 | + ar, err := NewArtifactReference("quay.io/podman/machine-os:5.1") |
| 17 | + assert.NoError(t, err) |
| 18 | + assert.NotNil(t, ar.Named) |
| 19 | + assert.Equal(t, "quay.io/podman/machine-os:5.1", ar.Named.String()) |
| 20 | + |
| 21 | + // Test another valid reference |
| 22 | + ar, err = NewArtifactReference("docker.io/library/nginx:latest") |
| 23 | + assert.NoError(t, err) |
| 24 | + assert.NotNil(t, ar.Named) |
| 25 | + |
| 26 | + // Test invalid reference - empty string |
| 27 | + _, err = NewArtifactReference("") |
| 28 | + assert.Error(t, err) |
| 29 | + |
| 30 | + // Test invalid reference - malformed |
| 31 | + _, err = NewArtifactReference("invalid::reference") |
| 32 | + assert.Error(t, err) |
| 33 | + |
| 34 | + // Test latest is added when no tag is provided |
| 35 | + ar, err = NewArtifactReference("quay.io/machine-os/podman") |
| 36 | + assert.NoError(t, err) |
| 37 | + assert.Equal(t, "quay.io/machine-os/podman:latest", ar.Named.String()) |
| 38 | + |
| 39 | + // Input with a digest is good |
| 40 | + ar, err = NewArtifactReference("quay.io/machine-os/podman@sha256:8b96f36deaf1d2713858eebd9ef2fee9610df8452fbd083bbfa7dca66d6fcd0b") |
| 41 | + assert.NoError(t, err) |
| 42 | + assert.True(t, ar.IsDigested()) |
| 43 | + |
| 44 | + // Partial digests are a no-go |
| 45 | + _, err = NewArtifactReference("quay.io/machine-os/podman@sha256:8b96f36deaf1d2") |
| 46 | + assert.Error(t, err) |
| 47 | + |
| 48 | + // "IDs" are also a no-go |
| 49 | + _, err = NewArtifactReference("84ddb405470e733d0202d6946e48fc75a7ee231337bdeb31a8579407a7052d9e") |
| 50 | + assert.Error(t, err) |
| 51 | +} |
| 52 | + |
| 53 | +func TestArtifactReference_IsDigested(t *testing.T) { |
| 54 | + // Test reference with tag (not digested) |
| 55 | + ar, err := NewArtifactReference("quay.io/podman/machine-os:5.1") |
| 56 | + require.NoError(t, err) |
| 57 | + assert.False(t, ar.IsDigested()) |
| 58 | + |
| 59 | + // Test reference with digest (digested) |
| 60 | + ar, err = NewArtifactReference("quay.io/podman/machine-os@sha256:8b96f36deaf1d2713858eebd9ef2fee9610df8452fbd083bbfa7dca66d6fcd0b") |
| 61 | + require.NoError(t, err) |
| 62 | + assert.True(t, ar.IsDigested()) |
| 63 | + |
| 64 | + // Test reference with latest tag (not digested) |
| 65 | + ar, err = NewArtifactReference("quay.io/podman/machine-os:latest") |
| 66 | + require.NoError(t, err) |
| 67 | + assert.False(t, ar.IsDigested()) |
| 68 | +} |
| 69 | + |
| 70 | +func TestNewArtifactStorageReference_ValidReference(t *testing.T) { |
| 71 | + repo := "quay.io/podman/machine-os" |
| 72 | + tag := "5.1" |
| 73 | + ref := fmt.Sprintf("%s:%s", repo, tag) |
| 74 | + as, artifactDigest := setupNewStore(t, ref, nil, nil) |
| 75 | + |
| 76 | + // Test with a valid named reference - should find the artifact in the store |
| 77 | + asr, err := NewArtifactStorageReference(ref, as) |
| 78 | + assert.NoError(t, err) |
| 79 | + assert.NotNil(t, asr.Ref) |
| 80 | + assert.Equal(t, "quay.io/podman/machine-os:5.1", asr.Ref.String()) |
| 81 | + assert.False(t, asr.IsDigested) |
| 82 | + assert.NotNil(t, asr.ArtifactFromStore) |
| 83 | + assert.Equal(t, "quay.io/podman/machine-os:5.1", asr.ArtifactFromStore.Name) |
| 84 | + |
| 85 | + // Lookup by Digest |
| 86 | + asr, err = NewArtifactStorageReference(fmt.Sprintf("%s@%s", repo, artifactDigest.String()), as) |
| 87 | + assert.NoError(t, err) |
| 88 | + assert.NotNil(t, asr.ArtifactFromStore) |
| 89 | + assert.True(t, asr.IsDigested) |
| 90 | + assert.NotNil(t, asr.ArtifactFromStore) |
| 91 | +} |
| 92 | + |
| 93 | +func TestNewArtifactStorageReference_AutoTagLatest(t *testing.T) { |
| 94 | + repoNameOnly := "quay.io/podman/machine-os" |
| 95 | + as, _ := setupNewStore(t, repoNameOnly, nil, nil) |
| 96 | + |
| 97 | + // Test with a reference without a tag (should auto-add :latest) |
| 98 | + asr, err := NewArtifactStorageReference(repoNameOnly, as) |
| 99 | + assert.NoError(t, err) |
| 100 | + assert.NotNil(t, asr.Ref) |
| 101 | + assert.Equal(t, fmt.Sprintf("%s:latest", repoNameOnly), asr.Ref.String()) |
| 102 | + assert.False(t, asr.IsDigested) |
| 103 | +} |
| 104 | + |
| 105 | +func TestNewArtifactStorageReference_InvalidReference(t *testing.T) { |
| 106 | + storePath := filepath.Join(t.TempDir(), "store") |
| 107 | + sc := &types.SystemContext{} |
| 108 | + |
| 109 | + // Create an artifact store |
| 110 | + as, err := NewArtifactStore(storePath, sc) |
| 111 | + require.NoError(t, err) |
| 112 | + require.NotNil(t, as) |
| 113 | + |
| 114 | + // Test with an invalid reference that also doesn't exist in the store |
| 115 | + // This should fail both as a reference parse and as a store lookup |
| 116 | + _, err = NewArtifactStorageReference("nonexistent-digest-12345", as) |
| 117 | + assert.Error(t, err) |
| 118 | +} |
| 119 | + |
| 120 | +func TestNewArtifactStorageReference_EmptyString(t *testing.T) { |
| 121 | + storePath := filepath.Join(t.TempDir(), "store") |
| 122 | + sc := &types.SystemContext{} |
| 123 | + |
| 124 | + // Create an artifact store |
| 125 | + as, err := NewArtifactStore(storePath, sc) |
| 126 | + require.NoError(t, err) |
| 127 | + require.NotNil(t, as) |
| 128 | + |
| 129 | + // Test with empty string |
| 130 | + _, err = NewArtifactStorageReference("", as) |
| 131 | + assert.Error(t, err) |
| 132 | +} |
| 133 | + |
| 134 | +func TestStringToNamed(t *testing.T) { |
| 135 | + // Test valid named reference |
| 136 | + named, err := stringToNamed("quay.io/podman/machine-os:5.1") |
| 137 | + assert.NoError(t, err) |
| 138 | + assert.NotNil(t, named) |
| 139 | + assert.Equal(t, "quay.io/podman/machine-os:5.1", named.String()) |
| 140 | + |
| 141 | + // Test reference without tag (should add :latest) |
| 142 | + named, err = stringToNamed("quay.io/podman/machine-os") |
| 143 | + assert.NoError(t, err) |
| 144 | + assert.NotNil(t, named) |
| 145 | + assert.Equal(t, "quay.io/podman/machine-os:latest", named.String()) |
| 146 | + |
| 147 | + // Test reference with digest |
| 148 | + named, err = stringToNamed("quay.io/podman/machine-os@sha256:8b96f36deaf1d2713858eebd9ef2fee9610df8452fbd083bbfa7dca66d6fcd0b") |
| 149 | + assert.NoError(t, err) |
| 150 | + assert.NotNil(t, named) |
| 151 | + assert.Equal(t, "quay.io/podman/machine-os@sha256:8b96f36deaf1d2713858eebd9ef2fee9610df8452fbd083bbfa7dca66d6fcd0b", named.String()) |
| 152 | + |
| 153 | + // Test invalid reference |
| 154 | + _, err = stringToNamed("invalid::reference") |
| 155 | + assert.Error(t, err) |
| 156 | + |
| 157 | + // Test empty string |
| 158 | + _, err = stringToNamed("") |
| 159 | + assert.Error(t, err) |
| 160 | +} |
| 161 | + |
| 162 | +func TestNewArtifactStore(t *testing.T) { |
| 163 | + // Test with valid absolute path |
| 164 | + storePath := filepath.Join(t.TempDir(), "store") |
| 165 | + sc := &types.SystemContext{} |
| 166 | + |
| 167 | + as, err := NewArtifactStore(storePath, sc) |
| 168 | + assert.NoError(t, err) |
| 169 | + assert.NotNil(t, as) |
| 170 | + assert.Equal(t, storePath, as.storePath) |
| 171 | + |
| 172 | + // Verify the index file was created |
| 173 | + indexPath := filepath.Join(storePath, "index.json") |
| 174 | + _, err = os.Stat(indexPath) |
| 175 | + assert.NoError(t, err) |
| 176 | + |
| 177 | + // Test with empty path |
| 178 | + _, err = NewArtifactStore("", sc) |
| 179 | + assert.Error(t, err) |
| 180 | + assert.Contains(t, err.Error(), "store path cannot be empty") |
| 181 | + |
| 182 | + // Test with relative path |
| 183 | + _, err = NewArtifactStore("relative/path", sc) |
| 184 | + assert.Error(t, err) |
| 185 | + assert.Contains(t, err.Error(), "must be absolute") |
| 186 | +} |
0 commit comments