Skip to content

Commit 4877783

Browse files
committed
Use $BINDIR as the default helper binary directory on Windows
The default helper binary directory on Windows was hardcoded. However the new user-scope installer deploys the binaries on a distinct directory. As a consequence `podman machine start` fails because gvproxy/winssh-proxy cannot be found. This problem affects Hyper-V, not WSL. To fix the problem we are using $BINDIR that is used by the function FindHelperBinaries to look in the directory where podman is located. Fixes containers/podman#27603 Signed-off-by: Mario Loriedo <[email protected]>
1 parent 32a0839 commit 4877783

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

common/pkg/config/config_windows.go

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,5 +31,7 @@ func overrideContainersConfigPath() (string, error) {
3131
}
3232

3333
var defaultHelperBinariesDir = []string{
34-
"C:\\Program Files\\RedHat\\Podman",
34+
// FindHelperBinaries(), as a convention, interprets $BINDIR as the
35+
// directory where the current process binary (i.e. podman) is located.
36+
"$BINDIR",
3537
}

0 commit comments

Comments
 (0)